Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose #28

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Add docker compose #28

wants to merge 36 commits into from

Conversation

RCM7
Copy link

@RCM7 RCM7 commented Aug 4, 2016

Basically I added the docker-compose I usually use to spin up my game server.

This way all the mounts, port mapping, environment variables and build step is handled by docker-compose and specified in this file, reducing the size of the commands to something like:

docker-compose up -d
docker-compose down
docker-compose build

Any doubts just ask, but don't skip a look at the docker-compose documentation if you don't understand something.

Cheers

@bkuhl
Copy link
Collaborator

bkuhl commented Aug 4, 2016

@zopanix The Travis-CI build is failing because the environment variables haven't been configured in travis. Can you set that up please?

@zopanix
Copy link
Owner

zopanix commented Aug 8, 2016

Hey, the env vars are set, it should work now

@RCM7
Copy link
Author

RCM7 commented Aug 8, 2016

I don't believe using Travis CI is the best tool to build images automatically and put them in Docker Hub since Docker Hub themselves support github integration and automatic builds of images...

So unless Travis CI is running some tests on the image, I don't think it should be used at all.

@bkuhl
Copy link
Collaborator

bkuhl commented Aug 8, 2016

The value Travis-CI adds over Dockerhub is that it can tag the images in accordance with the GitHub release version number. Dockerhub isn't capable of this kind of integration.

@RCM7
Copy link
Author

RCM7 commented Aug 8, 2016

Beg to disagree. It is possible and they even show you how with examples in the page where you set it up

EDIT:
screen shot 2016-08-08 at 21 46 02

@bkuhl
Copy link
Collaborator

bkuhl commented Aug 8, 2016

You're totally right, I don't remember seeing this. This could replace the travis integration. The full docs are here: https://docs.docker.com/docker-hub/github/

@zopanix
Copy link
Owner

zopanix commented Aug 9, 2016

@RCM7 @bkuhl : I already tried using docker build tools but it didn't work that well. I don't have as many options as you show on your screenshot and, while everything is configured correctly, I've never seen an automated build starting on its own. That's why I've chosen travis ci to manage this.
It might I don't get how it works :p

@RCM7
Copy link
Author

RCM7 commented Aug 9, 2016

@zopanix I understand that. I tried to reproduce the steps in a dummy project, and while some may seem confusing, it all checked out and it works. If you'd give it a try I'm glad to help with anything :)

@RCM7
Copy link
Author

RCM7 commented Aug 16, 2016

Ping 😄

@bkuhl
Copy link
Collaborator

bkuhl commented Aug 17, 2016

Upgrading this would be on @zopanix unless he wants to give me access to the Dockerhub repo as well.

@zopanix
Copy link
Owner

zopanix commented Aug 24, 2016

Hey, sorry I've been inactive bud I'm getting installed in my new home. I moved to canada from France it will take me a week or two to be completely operationnal :)

Copy link
Contributor

@psykzz psykzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the default network and overridden environment variables.

- factorio_net
restart: always

networks:
Copy link
Contributor

@psykzz psykzz Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify a network as one is automatically created with bridge type.

- ./mods:/opt/factorio/mods
ports:
- "34197:34197/udp"
environment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults for the environment are already provided in the Dockerfile, is there a need to redefine them?

@RCM7
Copy link
Author

RCM7 commented Oct 7, 2016

Sorry for the delay, I was out in vacation and then too occupied catching up with work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants