Make all classes new-style. This is especially good for PyPy #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zopefoundation/ZODB#160 for rationale.
Also restore PyPy to the build matrix.
I didn't try too hard to benchmark the actual improvements because there's a bug in the latest PyPy's (5.7.1) jit (I presume) that caused crashes (even with ZEO 4) under heavy loads (mostly on the client in ZEO5, mostly on the server in ZEO 4, interestingly enough). I did verify that under light load it at least performed no worse than before, both with and without zopefoundation/ZODB#160 being applied.