Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify FUTURE_PYTHON_VERSION as version range #218

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

dataflake
Copy link
Member

See https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-a-python-version and scroll down to hyphen ranges: It's apparently possible to specify a range of versions for a Python version to be used with the GitHub setup-python action. That way we won't have to update this package for every new prerelease. It also means testing for the value of FUTURE_PYTHON_VERSION to determine if with_future_python has to be set is no longer necessary. Only the package's future-python setting is considered.

This is not fully tested because there's no Python 3.13 preprelease yet.

@dataflake dataflake added the enhancement New feature or request label Oct 11, 2023
@dataflake dataflake self-assigned this Oct 11, 2023
mauritsvanrees added a commit to zopefoundation/zope.exceptions that referenced this pull request Oct 11, 2023
This is a testing PR for zopefoundation/meta#218
It introduces Python hyphen ranges in `tests.yml` for the future Python 3.13.
Manually added `3.11.0 - 3.11.2` to see the effect for a current Python.

To make the code differences smaller, this branch is based on #30 which updated to latest meta three weeks ago.
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out in zopefoundation/zope.exceptions#31 and the version ranges seem to work as intended.

@dataflake dataflake merged commit 8890ff6 into master Oct 14, 2023
4 checks passed
@dataflake dataflake deleted the dataflake/future_python_range branch October 14, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants