Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project's license: redeclare as PSF-2.0 #15

Closed
befeleme opened this issue May 17, 2023 · 11 comments · Fixed by #16
Closed

Project's license: redeclare as PSF-2.0 #15

befeleme opened this issue May 17, 2023 · 11 comments · Fixed by #16
Assignees
Labels

Comments

@befeleme
Copy link

FEATURE REQUEST

TL;DR: Python 2.1.1 is not a valid SPDX identifier, would it be possible to redeclare the project as PSF-2.0?

Hello,
Fedora Linux is going through the process of declaring the licenses according to the SPDX standard.
I was pointed here from docutils where we've came across the roman's license: Python 2.1.1, which is not an existing SPDX identifier. Having asked Fedora Legal for an opinion, it was pointed out that the original declaration by Mark Pilgrim was this:

"The example programs in this book are free software; you can redistribute and/or modify them under the terms of the Python license as published by the Python Software Foundation. A copy of the license is included in Appendix H, Python license."

And suggestion by the Legal team member:

I would suggest they replace the Python 2.1.1 license text with some sort of instantiation of the PSF-2.0 license text, and possibly attempt to get in touch with Mark Pilgrim to confirm that this is appropriate.

Would it be possible?

docutils issue
Fedora Legal issue

@dataflake
Copy link
Member

I have a suggestion since you're the party desiring this change: You get in touch with Mark Pilgrim and ask him if that's OK and ask him to either add a comment to that effect here or email zope-dev@zope.dev (or you forward his answer to you to zope-dev@zope.dev). I'll be happy to make the change then.

@pilgrim-brave
Copy link

I am the original author, and this license change is fine with me.

@icemac icemac self-assigned this May 23, 2023
icemac pushed a commit that referenced this issue May 23, 2023
@icemac
Copy link
Member

icemac commented May 23, 2023

@pilgrim-brave Thank you for your permit.

@befeleme I created a PR in #16. Is this the change you requested?
There is also https://github.com/zopefoundation/roman/blob/master/LICENSE.txt. Can this file be kept a is or does it also need changes?

@icemac icemac assigned befeleme and unassigned icemac May 23, 2023
@dataflake
Copy link
Member

Yes, I believe the license text file must be changed, otherwise the declared license no longer matches the shipped license file. The license file contains the "Python 2.0 license" (see https://www.python.org/download/releases/2.0/license/), which is not the same as PSF-2.0, which is the "Python Software Foundation License 2.0".

I found the license text for the PSF-2.0 license at https://wiki.python.org/moin/PythonSoftwareFoundationLicenseV2Easy and here's a link that shows how to modify the PSF for use in projects that are not owned by the PSF: https://wiki.python.org/moin/PythonSoftwareFoundationLicenseFaq#How_do_I_use_the_PSF_License.3F

@befeleme
Copy link
Author

@befeleme I created a PR in #16. Is this the change you requested? There is also https://github.com/zopefoundation/roman/blob/master/LICENSE.txt. Can this file be kept a is or does it also need changes?

Please also change the license file to achieve consistency. Thank you!

@icemac
Copy link
Member

icemac commented May 24, 2023

@dataflake Thank you for digging up the licence and providing a howto to alter it. I did it in #16 but the text feels wrong. It seems no longer to be PSF-2.0 but more like a completely new licence. Could we alternatively use the actual Zope Public License (ZPL-2.1) instead?

@dataflake
Copy link
Member

This is a question for @befeleme.

To me it looks like the original license declaration by @pilgrim-brave was already impossible to implement - the Python 2.0 license as well as the PSF-2.0 represent a license contract between the PSF and the end user. But this software package was never owned by the PSF so that made no sense back then and it makes no sense now.

The PSF license howto says you should edit the license text and not use it as-is. I do not know if it's even valid to call such a changed license text "PSF-2.0" anymore. I'm not a lawyer but would guess no.

If I had a choice I would ask Mark if it's OK to use the Zope Public License version 2.1 instead. The package is already in the GitHub "zopefoundation" organization and it's one of a handful (out of 300+ packages) that does not use the ZPL. The ZPL is also OSI certified: https://opensource.org/license/zpl-2-1/.

@pilgrim-brave would you agree to change the license to the ZPL version 2.1? I would also add a dedicated copyright notice file that explicitly names "Mark Pilgrim and contributors" as copyright holder and add a copyright note at the top of all source code files similar to what we have in all other projects, something like this:

##############################################################################
#
# Copyright (c) 2001 Mark Pilgrim and Contributors.
# All Rights Reserved.
#
# This software is subject to the provisions of the Zope Public License,
# Version 2.1 (ZPL).  A copy of the ZPL should accompany this distribution.
# THIS SOFTWARE IS PROVIDED "AS IS" AND ANY AND ALL EXPRESS OR IMPLIED
# WARRANTIES ARE DISCLAIMED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
# WARRANTIES OF TITLE, MERCHANTABILITY, AGAINST INFRINGEMENT, AND FITNESS
# FOR A PARTICULAR PURPOSE.
#
##############################################################################

@befeleme
Copy link
Author

This is a question for @befeleme.

I have no objections to any desired license change that's agreed by all parties (not counting self as a party). My initial query is about the inconsistency between the license declaration from the original source and the license text provided. As an RPM package maintainer, I'll welcome any consistent open-source outcome. Zope Public License version 2.1 is allowed in Fedora.

@pilgrim-brave
Copy link

@pilgrim-brave would you agree to change the license to the ZPL version 2.1?

Yes.

@dataflake
Copy link
Member

@befeleme Take a look at #16 and let me know what you think.

@dataflake
Copy link
Member

I just released version 4.1 with the new license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants