Fixed lowercase inputs #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code used to raise exception for lowercase inputs, when used roman.fromRoman('xvi') for example, it gave:
Exception occured: Invalid Roman numeral: xvi
I could fix this issue by adding lowercase entries to the maps and patterns, but this simple fix would also fix the issue, and not make the code more cluttered.
|
I have signed the Contributors Agreement for Zope. |
dataflake
approved these changes
Oct 1, 2024
|
Sorry for the delay, it took a few days for the application to go through and then show you as "Member" here. Please merge your change. |
|
No worries, though It tells me "Only those with write access to this repository can merge pull requests." |
|
As Member you do have the required access. |
|
I was just informed that the contributor agreement admins have changed their policy and created an "in between" status for new contributors that does not include the privileges to directly write to the repositories. This is in response to a flood of low-quality contributions. I have decided to just merge this myself. |
icemac
added a commit
that referenced
this pull request
Oct 2, 2024
icemac
added a commit
that referenced
this pull request
Oct 2, 2024
As #22 moved the conversion to upper case into the conversion function, it is no longer necessary to convert it in the main function.
This was referenced Oct 2, 2024
icemac
added a commit
that referenced
this pull request
Oct 8, 2024
As #22 moved the conversion to upper case into the conversion function, it is no longer necessary to convert it in the main function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to raise exception for lowercase inputs, when used roman.fromRoman('xvi') for example, it gave:
Exception occured: Invalid Roman numeral: xvi
I could fix this issue by adding lowercase entries to the maps and patterns, but this simple fix would also fix the issue, and not make the code more cluttered.