Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for multipart 1.0.0 #75

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Fixes for multipart 1.0.0 #75

merged 5 commits into from
Sep 25, 2024

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Sep 24, 2024 •
edited
Loading

  • The new multipart parser is strict about line endings, so be sure to use \r\n
  • The new multipart parser uses tempfile.SpooledTemporaryFile objects, which do not have a seekable() method on Python before 3.11.

This fixes both issues and makes the tests pass.

Closes #74, #44.

@mgedmin
Use CRLF line endings in tests
a44be99 
The new parser in multipart 1.0.0 requires CRLF rather than LF line
endings: defnull/multipart#55

Fixes most of #74.  The one remaining failure is a regression of #44
(lack of `.seekable()` on FileUpload objects).
@mgedmin
Implement FileUpload.seekable() for Pythons < 3.11
f6ea516 
Fixes #44.
davisagli
davisagli reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Needs a changelog entry and a typo fix.

src/zope/publisher/browser.py Outdated Show resolved Hide resolved
mgedmin and others added 2 commits September 25, 2024 08:35
@mgedmin @davisagli
Fix typo in comment
649814c 
Co-authored-by: David Glick <david@glicksoftware.com>
@mgedmin
Mention the multipart 1.0.0 fixes in the changelog
31238c6
icemac
icemac approved these changes Sep 25, 2024
View reviewed changes
src/zope/publisher/browser.py Outdated Show resolved Hide resolved
@mgedmin @icemac
Add a comment
6b9710a 
Mention the range of Python versions that need the workaround so we can remove it once Python 3.10 goes EOL.

Co-authored-by: Michael Howitz <icemac@gmx.net>
@mgedmin mgedmin merged commit 7f077e9 into master Sep 25, 2024
12 checks passed
@mgedmin mgedmin deleted the fix-for-multipart-1.0.0 branch September 25, 2024 07:11
@mgedmin
Copy link
Member Author

mgedmin commented Sep 25, 2024 •
edited
Loading

I would like a zope.publisher 7.0.1 release. Are we still using zest.releaser to make releases?

Also, I think I should add Python 3.12 to the build matrix before I pull the trigger. Maybe drop 3.7 while at it.

@icemac
Copy link
Member

icemac commented Sep 26, 2024

I would like a zope.publisher 7.0.1 release. Are we still using zest.releaser to make releases?

Yes, zest.releaser is still the tool I use for all releases.

wosc added a commit to ZeitOnline/vivi that referenced this pull request Dec 27, 2024
@wosc
MAINT: Respect stricter HTTP line endings for multipart-1.x, see zope…
da9c5e8 
…foundation/zope.publisher#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests break with multipart >= 1.0
3 participants
@mgedmin @icemac @davisagli