Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSL-JSON hardening #109

Merged
merged 11 commits into from
May 17, 2021
Merged

CSL-JSON hardening #109

merged 11 commits into from
May 17, 2021

Commits on Apr 22, 2021

  1. Configuration menu
    Copy the full SHA
    b1a9035 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad9d7f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b813d00 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Configuration menu
    Copy the full SHA
    f98123d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83e65f6 View commit details
    Browse the repository at this point in the history
  3. delete comment about pandoc dates being incompatible

    technically `literal` and `year` keys are in CSL-JSON
    or at least they are now
    cormacrelf committed May 14, 2021
    Configuration menu
    Copy the full SHA
    cdb77ec View commit details
    Browse the repository at this point in the history
  4. add JSON input test suite

    - updated serde because I thought it would fix an issue,
      may as well keep it
    cormacrelf committed May 14, 2021
    Configuration menu
    Copy the full SHA
    ec5a46f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    112840d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    743ae28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    407cc96 View commit details
    Browse the repository at this point in the history
  8. harden & test CSL-JSON Reference input pretty thoroughly

    all this was done through the new crates/io/tests/json
    test suite.
    
    test:
    - parses the JSON schema to auto-generate test cases
    - tests for unknown variables
    - tests all classes of variable are parsed as the correct
      AnyVariable variant
    - tests that these tests are exhaustive
    
    test-suite:
    - adds date_IsUncertainDate as a pure boolean test
    
    dates:
    - also fixes <if is-uncertain-date="issued"> not being implemented
      (it passed date_Uncertain spuriously, because it rendered circa term anyway)
    - ignores unrecognised fields in dates
    - ignores additional entries in date-parts arrays
    - ignores more invalid values
    - accepts bool for circa
    - stores circa on literal as well
    - log warnings for many cases
    
    variables:
    - adds _everything_ from the latest CSL-JSON schema
    cormacrelf committed May 14, 2021
    Configuration menu
    Copy the full SHA
    e55963a View commit details
    Browse the repository at this point in the history