-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSL-JSON hardening #109
Merged
Merged
CSL-JSON hardening #109
Commits on Apr 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b1a9035 - Browse repository at this point
Copy the full SHA b1a9035View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad9d7f5 - Browse repository at this point
Copy the full SHA ad9d7f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b813d00 - Browse repository at this point
Copy the full SHA b813d00View commit details
Commits on May 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f98123d - Browse repository at this point
Copy the full SHA f98123dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83e65f6 - Browse repository at this point
Copy the full SHA 83e65f6View commit details -
delete comment about pandoc dates being incompatible
technically `literal` and `year` keys are in CSL-JSON or at least they are now
Configuration menu - View commit details
-
Copy full SHA for cdb77ec - Browse repository at this point
Copy the full SHA cdb77ecView commit details -
- updated serde because I thought it would fix an issue, may as well keep it
Configuration menu - View commit details
-
Copy full SHA for ec5a46f - Browse repository at this point
Copy the full SHA ec5a46fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 112840d - Browse repository at this point
Copy the full SHA 112840dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 743ae28 - Browse repository at this point
Copy the full SHA 743ae28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 407cc96 - Browse repository at this point
Copy the full SHA 407cc96View commit details -
harden & test CSL-JSON Reference input pretty thoroughly
all this was done through the new crates/io/tests/json test suite. test: - parses the JSON schema to auto-generate test cases - tests for unknown variables - tests all classes of variable are parsed as the correct AnyVariable variant - tests that these tests are exhaustive test-suite: - adds date_IsUncertainDate as a pure boolean test dates: - also fixes <if is-uncertain-date="issued"> not being implemented (it passed date_Uncertain spuriously, because it rendered circa term anyway) - ignores unrecognised fields in dates - ignores additional entries in date-parts arrays - ignores more invalid values - accepts bool for circa - stores circa on literal as well - log warnings for many cases variables: - adds _everything_ from the latest CSL-JSON schema
Configuration menu - View commit details
-
Copy full SHA for e55963a - Browse repository at this point
Copy the full SHA e55963aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.