Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v3/entrypoint schema #308

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Feature/v3/entrypoint schema #308

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fa6dbb
Merge branch 'v2.x/staging' into v3.x/staging
1000TurquoisePogs Jul 30, 2024
d28928b
Add schema item for custom entrypoint names
1000TurquoisePogs Jul 30, 2024
e16b8f4
Merge branch 'v3.x/staging' into feature/v3/entrypoint-schema
1000TurquoisePogs Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions schemas/plugindefinition-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,22 @@
"framework": {
"type": "string",
"enum": [ "angular2", "angular", "react" ]
},
"entryPoint": {
"type": "object",
"description": "Describes a path, relative to the app's '/web' folder in the browser, where the main file is that will be loaded by the Zowe Desktop. This is assumed to be 'main.js' for Zowe versions older than v3 but allows you to ship multiple entryPoints to target different versions of Zowe",
"additionalProperties": false,
"properties": {
"2.0": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be for 2.0, 3.0 won't be for 3.0 etc. this will be for V2 or V3 right? So let's change it to
"v2" or "2" and "v3" or "3"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its intended to be a version number, so that if a change is needed there can be a "3.1", "3.2", etc.

"const": "main.js",
"type": "string",
"description": "This property is not configurable. The Zowe Desktop in v2 will always search for web/main.js. This entry is just defined to document this fact."
},
"3.0": {
"type": "string",
"description": "This is a path, relative to the app's '/web' folder in the browser, where the main file that will be loaded by the Zowe Desktop is located. This should not be 'main.js' to avoid conflict with that name used in Zowe v2."
}
}
}
}
},
Expand Down
Loading