Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zowe bot should have a callable API to send DMs #17

Open
wants to merge 20 commits into
base: user/markackert/tls-options
Choose a base branch
from

Conversation

MarkAckert
Copy link
Member

@MarkAckert MarkAckert commented Mar 23, 2023

Addresses #12

Adds direct message support to mattermost, msteams, and slack. Code has been tested manually against all 3 client applications; additional unit tests pending.

Integration / system testing requires a separate PR effort.

Some minor refactors are being made in MSTeamsMiddleware in response to Sonar quality reports.

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@MarkAckert MarkAckert force-pushed the user/markackert/send-dms branch from 8cff19a to 6b9d7e3 Compare April 14, 2023 14:45
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the PR yet, but the basic premise of having a common middleware for each kind of chat technologies makes 100% sense to me.
In addition, this sets a nice precedence for adding new chats to create a middleware plug-in. 😋

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

58.1% 58.1% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants