Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export new Proxy class from imperative #2205

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

JillieBeanSim
Copy link
Contributor

What It Does

export new Proxy class from imperative

How to Test

Extenders can not import new class using 7.27.0 that introduced the new Proxy support, class needs to be exported from package.

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim
Copy link
Contributor Author

I'm sorry, I am not sure what the CHANGELOG header should be. I don't see an example in any of existing package files and the TBD Release header we use in ZE failed 🥲

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 requested a review from t1m0thyj July 24, 2024 13:01
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JillieBeanSim!

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.16%. Comparing base (a6193aa) to head (ab961e0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2205    +/-   ##
========================================
  Coverage   91.15%   91.16%            
========================================
  Files         638      638            
  Lines       19133    19134     +1     
  Branches     4041     3927   -114     
========================================
+ Hits        17441    17443     +2     
+ Misses       1691     1690     -1     
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awharn awharn merged commit 7500654 into zowe:master Jul 24, 2024
14 checks passed
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Jul 24, 2024
@JillieBeanSim JillieBeanSim deleted the export-proxy-class branch July 24, 2024 13:42
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/imperative@5.26.1
  • npm: @zowe/cli-test-utils@7.28.1
  • npm: @zowe/core-for-zowe-sdk@7.28.1
  • npm: @zowe/zos-uss-for-zowe-sdk@7.28.1
  • npm: @zowe/provisioning-for-zowe-sdk@7.28.1
  • npm: @zowe/zos-console-for-zowe-sdk@7.28.1
  • npm: @zowe/zos-files-for-zowe-sdk@7.28.1
  • npm: @zowe/zos-logs-for-zowe-sdk@7.28.1
  • npm: @zowe/zosmf-for-zowe-sdk@7.28.1
  • npm: @zowe/zos-workflows-for-zowe-sdk@7.28.1
  • npm: @zowe/zos-jobs-for-zowe-sdk@7.28.1
  • npm: @zowe/zos-tso-for-zowe-sdk@7.28.1
  • npm: @zowe/cli@7.28.1

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants