Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance cli-test-utils error when "sh" missing from PATH #2209

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

t1m0thyj
Copy link
Member

What It Does

Fixes #2208

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj force-pushed the fix/cli-test-utils-no-sh-error branch from 31922c5 to 6d178c2 Compare July 25, 2024 18:27
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (7500654) to head (6d178c2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2209   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files         638      638           
  Lines       19134    19134           
  Branches     3974     3927   -47     
=======================================
  Hits        17442    17442           
  Misses       1691     1691           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 25, 2024

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy for the fix!

@traeok traeok merged commit d9f4e7e into master Jul 25, 2024
19 checks passed
@traeok traeok deleted the fix/cli-test-utils-no-sh-error branch July 25, 2024 19:52
@traeok traeok added the release-patch Indicates a patch to existing code has been applied label Jul 25, 2024
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/cli-test-utils@7.28.2
  • npm: @zowe/core-for-zowe-sdk@7.28.2
  • npm: @zowe/zos-uss-for-zowe-sdk@7.28.2
  • npm: @zowe/provisioning-for-zowe-sdk@7.28.2
  • npm: @zowe/zos-console-for-zowe-sdk@7.28.2
  • npm: @zowe/zos-files-for-zowe-sdk@7.28.2
  • npm: @zowe/zos-logs-for-zowe-sdk@7.28.2
  • npm: @zowe/zosmf-for-zowe-sdk@7.28.2
  • npm: @zowe/zos-workflows-for-zowe-sdk@7.28.2
  • npm: @zowe/zos-jobs-for-zowe-sdk@7.28.2
  • npm: @zowe/zos-tso-for-zowe-sdk@7.28.2
  • npm: @zowe/cli@7.28.2

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Enhance error message returned by cli-test-utils when sh not on PATH
5 participants