System tests should cleanup after themselves #2216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2216 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 628 628
Lines 17821 17821
Branches 3820 3785 -35
=======================================
Hits 16264 16264
Misses 1556 1556
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
__tests__/__packages__/cli-test-utils/src/environment/TestEnvironment.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
ATorrise
force-pushed
the
system-test-cleanup
branch
from
0f61785
to
4f059e6
Compare
…iles from permanent residency, ,instead creating them from scratch everytime Signed-off-by: ATorrise <amber.torrise@broadcom.com>
…as matching for this test. also took a while to identify which shell script was populating 2 jobs Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
packages/cli/__tests__/zosjobs/__system__/download/cli.zos-jobs.download.output.system.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
…ests for cliZosJobs Signed-off-by: ATorrise <amber.torrise@broadcom.com>
packages/cli/__tests__/zosjobs/__system__/submit/stdin/cli.zos-jobs.submit.stdin.system.test.ts
Fixed
Show fixed
Hide fixed
packages/cli/__tests__/zosjobs/__system__/submit/stdin/cli.zos-jobs.submit.stdin.system.test.ts
Fixed
Show resolved
Hide resolved
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
|
Checks are currently failing due to failed imports. I think the package.json file for the cli-test-utils package needs to be updated to reflect the new dependencies on the Jobs and Files SDKs. |
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
t1m0thyj
reviewed
Aug 29, 2024
packages/cli/__tests__/zosjobs/__system__/cancel/cli.zos-jobs.cancel.job.system.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
packages/cli/__tests__/zosjobs/__system__/search/cli.zos-jobs.search.job.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
…d not IPLed to test Signed-off-by: ATorrise <amber.torrise@broadcom.com>
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
…into system-test-cleanup
zFernand0
requested changes
Sep 4, 2024
| * @memberof ITestEnvironment | ||
| */ | ||
| systemTestProperties: TestPropertiesSchema; |
There was a problem hiding this comment.
When using generics, it's advisable to keep the name short, and ideally something different to an existing interface.
you could get the same benefits by doing <T extends ITestPropertiesSchema> and use the value of T as the desired type for this properti (e.g. systemTestProperties: T)
Signed-off-by: ATorrise <amber.torrise@broadcom.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This PR enhances the test framework to simplify and automate the cleanup of test resources, such as datasets, USS files, jobs, and local files. The
TestEnvironment,ITestEnvironment, andTestUtilsclasses have been updated to track and delete resources after system tests, preventing any leftover artifacts on the mainframe or local filesystem.How to Test : Run System Tests
Review Checklist
I certify that I have:
Additional Comments
zowe-cli\packages\zosjobs\__tests__\__system__\MonitorJobs.system.test.tsonly had minor indentation changes and was left intact as it leaves no jobs behind on the mainframe.