-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] allow showMsgWhenDeprecated to accept an empty string as a parameter … #2226
Conversation
…to show an alternative error message Signed-off-by: jace-roell <jace.roell@hotmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2226 +/- ##
==========================================
- Coverage 91.24% 91.24% -0.01%
==========================================
Files 638 638
Lines 19142 19146 +4
Branches 3989 4057 +68
==========================================
+ Hits 17467 17470 +3
- Misses 1674 1675 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
…Deprecated() Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few edits - thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- thanks @jace-roell!
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jace-roell! Sorry for all the change requests. 🚀
It looks like the automation did something it shouldn't have done. It seems to have updated the change log to replace |
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Quality Gate failedFailed conditions |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Modified showMsgWhenDeprecated() to allow an empty string as a paramter when no replacement is availible for deprecated command to print an alternative message.
Review Checklist
I certify that I have: