v3 pre-release Sept week 2 #3106

JillieBeanSim · 2024-09-10T16:58:17Z

Proposed changes

v3 pre-release scheduled for week 2 of September

Release Notes

Milestone: v3 pre-release

Changelog: n/a

Types of changes

Bug fix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds or improves functionality)
Breaking change (a change that would cause existing functionality to not work as expected)
Documentation (Markdown, README updates)
Other (please specify above in "Proposed changes" section)

Checklist

General

I have read the CONTRIBUTOR GUIDANCE wiki
All PR dependencies have been merged and published (if applicable)
A GIF or screenshot is included in the PR for visual changes
The pre-publish command has been executed:
- v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
- v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

There is coverage for the code that I have added
I have added new test cases and they are passing
I have manually tested the changes

Deployment

I have added developer documentation (if applicable)
Documentation should be added to Zowe Docs
- If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
- Otherwise, please check with the rest of the squad about any needed documentation before merging.
These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

packages/zowe-explorer-api/src/profiles/ProfilesCache.ts

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

codecov · 2024-09-10T17:16:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (8146202) to head (f5c675a).
Report is 8 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff            @@
##             next    #3106    +/-   ##
========================================
  Coverage   92.57%   92.57%            
========================================
  Files         113      113            
  Lines       11635    11636     +1     
  Branches     2471     2579   +108     
========================================
+ Hits        10771    10772     +1     
  Misses        862      862            
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim · 2024-09-11T20:53:06Z

packages/zowe-explorer-api/src/profiles/ProfilesCache.ts

@@ -150,6 +150,7 @@ export class ProfilesCache {
            return;
        }
        const allTypes = this.getAllProfileTypes(apiRegister?.registeredApiTypes() ?? []);
+        allTypes.push("ssh");


This was added for extenders calling loadNamedProfile() or other profile fetching APIs for a SSH profile. possible regression as it previously worked.

Sounds like a good idea to resolve the regression for now, but curious if we should discuss this a bit more 😋

I guess I'm trying to understand how/when the regression started, since I don't recall us having to add the ssh profile as part of the loaded types.

Personal guess: Maybe because we moved to individual SDKs?

Also curious why we need to hardcode "ssh" here, since other core profile types ("zosmf" and "tso") seem to work without being manually added to the array.

zosmf is added to the registered profile list when registered during activation, left comment about double checking tso if it's a regression and possibly updating to register the other types similar to how cics profiles register.

JillieBeanSim · 2024-09-11T20:53:38Z

packages/zowe-explorer-api/CHANGELOG.md

 ### Bug fixes

- Fixed errors being logged silently rather than thrown in `ProfilesCache.refresh` method. [#3066](https://github.com/zowe/zowe-explorer-vscode/issues/3066)


this changelog entry exists under 2.18.0

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim · 2024-09-11T20:56:45Z

packages/zowe-explorer/CHANGELOG.md


- Fixed JSON errors being ignored when `zowe.config.json` files change on disk and are reloaded. [#3066](https://github.com/zowe/zowe-explorer-vscode/issues/3066) [#3074](https://github.com/zowe/zowe-explorer-vscode/issues/3074)


this changelog entry exists under 2.18.0

github-actions · 2024-09-12T13:42:49Z

📅 Suggested merge-by date: 9/26/2024

Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>

sonarcloud · 2024-09-13T13:09:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

likhithanimma1

Changes look good to me @JillieBeanSim . Thankyou :)

SanthoshiBoyina1

LGTM. Thanks for the work @JillieBeanSim

zFernand0

LGTM! 😋
Left a few comments just wondering about the SSH regression.

zFernand0 · 2024-09-13T18:23:17Z

packages/zowe-explorer-api/CHANGELOG.md

 ### Bug fixes

- Fixed errors being logged silently rather than thrown in `ProfilesCache.refresh` method. [#3066](https://github.com/zowe/zowe-explorer-vscode/issues/3066)
+- Fix extender's ability to fetch profile information from ProfilesCache for SSH profile types.


Curious if we should add this PR as a link.
Also, wondering how the regression occurred.

zFernand0 · 2024-09-13T18:24:37Z

packages/zowe-explorer-api/__tests__/__unit__/profiles/ProfilesCache.unit.test.ts

@@ -309,7 +309,7 @@ describe("ProfilesCache", () => {
            expect((profCache as any).profilesByType.size).toBe(0);
            expect((profCache as any).defaultProfileByType.size).toBe(0);
            expect((profCache as any).allProfiles.length).toBe(0);
-            expect((profCache as any).allTypes).toEqual(["base"]);
+            expect((profCache as any).allTypes).toEqual(["ssh", "base"]);


Would extenders trying to load tso or zosmf profiles have the same prroblem?

zFernand0 · 2024-09-13T18:27:03Z

packages/zowe-explorer-api/src/profiles/ProfilesCache.ts

@@ -150,6 +150,7 @@ export class ProfilesCache {
            return;
        }
        const allTypes = this.getAllProfileTypes(apiRegister?.registeredApiTypes() ?? []);
+        allTypes.push("ssh");


Sounds like a good idea to resolve the regression for now, but curious if we should discuss this a bit more 😋

I guess I'm trying to understand how/when the regression started, since I don't recall us having to add the ssh profile as part of the loaded types.

Personal guess: Maybe because we moved to individual SDKs?

JillieBeanSim · 2024-09-13T21:14:19Z

we can def look at better way and test the TSO as I have not, it could be due to the change to SDKs. zosmf profiles are registered during ZE activation so included in the registered profiles array. Maybe ssh and tso should get registered as an alternate type like cics.

JillieBeanSim added 2 commits September 9, 2024 14:26

move CHANGELOG entries to correct location

305dce0

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

add SSH to array of profiles loaded

0185dc0

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim added the no-changelog Add to PR's that don't require a CHANGELOG update label Sep 10, 2024

JillieBeanSim self-assigned this Sep 10, 2024

pull-request-size bot added the size/XS label Sep 10, 2024

JillieBeanSim commented Sep 10, 2024

View reviewed changes

packages/zowe-explorer-api/src/profiles/ProfilesCache.ts Outdated Show resolved Hide resolved

fix unit tests

89996fe

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

pull-request-size bot added size/S and removed size/XS labels Sep 10, 2024

JillieBeanSim added this to the v3 pre-releases milestone Sep 10, 2024

JillieBeanSim added 2 commits September 10, 2024 13:22

add CHANGELOG item for SSH fix

2ba157b

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

Merge remote-tracking branch 'origin/next' into pre-release/sept-week2

a077cba

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim commented Sep 11, 2024

View reviewed changes

remove changelog entry for 2.18.0 item

776ffbc

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>

JillieBeanSim commented Sep 11, 2024

View reviewed changes

JillieBeanSim marked this pull request as ready for review September 12, 2024 13:42

JillieBeanSim requested review from zFernand0, t1m0thyj and traeok September 12, 2024 13:42

Merge branch 'next' into pre-release/sept-week2

f5c675a

Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>

likhithanimma1 self-requested a review September 13, 2024 17:36

likhithanimma1 approved these changes Sep 13, 2024

View reviewed changes

SanthoshiBoyina1 approved these changes Sep 13, 2024

View reviewed changes

zFernand0 approved these changes Sep 13, 2024

View reviewed changes

JillieBeanSim merged commit 3838594 into next Sep 13, 2024
24 checks passed

JillieBeanSim deleted the pre-release/sept-week2 branch September 13, 2024 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3 pre-release Sept week 2 #3106

v3 pre-release Sept week 2 #3106

JillieBeanSim commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading

JillieBeanSim Sep 11, 2024

zFernand0 Sep 13, 2024

t1m0thyj Sep 13, 2024 •

edited

Loading

JillieBeanSim Sep 17, 2024

JillieBeanSim Sep 11, 2024

JillieBeanSim Sep 11, 2024

github-actions bot commented Sep 12, 2024

sonarcloud bot commented Sep 13, 2024

likhithanimma1 left a comment

SanthoshiBoyina1 left a comment

zFernand0 left a comment

zFernand0 Sep 13, 2024

zFernand0 Sep 13, 2024

zFernand0 Sep 13, 2024

JillieBeanSim commented Sep 13, 2024 •

edited

Loading

		### Bug fixes

		- Fixed errors being logged silently rather than thrown in `ProfilesCache.refresh` method. [#3066](https://github.com/zowe/zowe-explorer-vscode/issues/3066)


		- Fixed JSON errors being ignored when `zowe.config.json` files change on disk and are reloaded. [#3066](https://github.com/zowe/zowe-explorer-vscode/issues/3066) [#3074](https://github.com/zowe/zowe-explorer-vscode/issues/3074)

v3 pre-release Sept week 2 #3106

v3 pre-release Sept week 2 #3106

Conversation

JillieBeanSim commented Sep 10, 2024 • edited Loading

Proposed changes

Release Notes

Types of changes

Checklist

Further comments

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

t1m0thyj Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 12, 2024

sonarcloud bot commented Sep 13, 2024

Quality Gate passed

likhithanimma1 left a comment

Choose a reason for hiding this comment

SanthoshiBoyina1 left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JillieBeanSim commented Sep 13, 2024 • edited Loading

JillieBeanSim commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading

t1m0thyj Sep 13, 2024 •

edited

Loading

JillieBeanSim commented Sep 13, 2024 •

edited

Loading