fix(V3): Edit team config fails with global & project level present

[SanthoshiBoyina1]

Proposed changes

Solves #3125
To fix Edit team config fails with global & project level present

Release Notes

Milestone:

Changelog:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[github-actions]

📅 Suggested merge-by date: 10/7/2024

[JillieBeanSim]

LGTM! thanks for the fix @SanthoshiBoyina1

[t1m0thyj]

Will approve once Trae's comment is addressed - creating zowe.config.user.json files should not be the default behavior, as the purpose of User Config is solely to override values in zowe.config.json.

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (71f995d) to head (99b0a65).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
...ckages/zowe-explorer/src/configuration/Profiles.ts	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
- Coverage   92.79%   92.79%   -0.01%     
==========================================
  Files         113      113              
  Lines       11663    11669       +6     
  Branches     2593     2501      -92     
==========================================
+ Hits        10823    10828       +5     
- Misses        838      839       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zFernand0]

left a small comment on the changelog 😅

[JillieBeanSim]

Hey all, I tried a different approach. Let me know what you think @traeok @t1m0thyj @zFernand0

FYI @SanthoshiBoyina1

Edit: sorry, not to look like I'm just barging in on the PR. Santhoshi asked me to help look into resolving the concerns raised in PR.

[zFernand0]

LGTM! 😋

Left a small comment about an edge-case. 😅
But it's a bit rare for someone to want to update their config by opening their zoweDir and selecting project as their choice 😋

[anaxceron]

Looks great, thanks @SanthoshiBoyina1!

[t1m0thyj]

I think the change on this line could be reverted to address Fernando's comment 😋

Suggested change

	if (file.path.includes(FileManagement.getZoweDir())) {
	if (file.global) {

[traeok]

As Timothy mentioned, it looks like we'll need to change the logic back for case "global" so that it handles opening files in the Zowe dir as well.

Will approve once resolved 😋

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[JillieBeanSim]

LGTM! thanks @SanthoshiBoyina1 for the fix

addressed