Add option to restrict overriding authorize_options by user request #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the great gem!
By the following implementation, all authorize_options can be overridden with request parameters.
omniauth-google-oauth2/lib/omniauth/strategies/google_oauth2.rb
Lines 34 to 36 in 8bebf08
For example, even if we restrict it with
hd: 'exanple.com'
, end-users can use anyhd
with/oauth/google_oauth2?hd=example.net
.It's flexible and convenient, but it may be unexpected behavior in some apps.
I have added an option to control this behavior with this pull request.
If you don't need this change, feel free to close it.
Thanks,