follow jwt 2.9.0 changes #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't mind this change, but we will need to bump a minor version and cut this as version 1.2. This bumps our Ruby dependency from >= 2.2 to >= 2.5. Many people who use this software will not be able to do this change. That being said, keeping current is important. We should also bump the Ruby requirement in the Gemfile. |
|
do you want me to update the version too? |
|
OK, updated gem & ruby versions. |
|
This looks legit, lets merge and I will focus on any other minor changes and push a release. =) |
|
New release is out. =) |
nevans
added a commit
to nevans/omniauth-google-oauth2
that referenced
this pull request
Oct 3, 2024
This is a continuation of zquestz#464, which fixed backward compatibility with jwt v2.9.0 and v2.9.1. v2.9.2 brought back the removed APIs, for backward compatibility, but marked them as internal only and/or deprecated. For context, see the discussion here: * jwt/ruby-jwt#623 * jwt/ruby-jwt#626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #463
JWT::Verify.verify_claims->JWT::Claims.verify!