Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal zaw source option options into src_opts #94

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

termoshtt
Copy link
Contributor

@termoshtt termoshtt commented Jan 26, 2018

Resolve #93, and related to zsh-users/zsh-syntax-highlighting#500

This will be a large breaking change since this PR changes how to define sources.

@termoshtt termoshtt added the Bug label Jan 26, 2018
@magthe
Copy link

magthe commented Feb 1, 2018

I'm currently using this branch of zaw in my setup and can report that it works well! :)

@magthe
Copy link

magthe commented Feb 9, 2018

Is there anything in particular holding the merge back? Maybe something I can do to help speed it along?

@termoshtt
Copy link
Contributor Author

Sorry for later work :<
I'm considering how to avoid incompatibility issues for external zaw source e.g. zaw-systemd. I have no idea to resolve this problem except for add a document for "how to write zaw source". I will make issue for it, and close this PR. Thanks

@termoshtt termoshtt changed the title Rename options Rename internal zaw source option options into src_opts Feb 9, 2018
@termoshtt termoshtt merged commit 5874965 into master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants