Always reset file descriptor after consuming it

[codicodi]

This prevents the request cancelling logic from closing an unrelated fd that happens to reuse the same number.

zsh-autosuggestions/src/async.zsh

Lines 12 to 15 in a411ef3

	if [[ -n "$_ZSH_AUTOSUGGEST_ASYNC_FD" ]] && { true <&$_ZSH_AUTOSUGGEST_ASYNC_FD } 2>/dev/null; then
	# Close the file descriptor and remove the handler
	exec {_ZSH_AUTOSUGGEST_ASYNC_FD}<&-
	zle -F $_ZSH_AUTOSUGGEST_ASYNC_FD

[ericfreese]

Hey, thanks for this. I stumbled across the same issue while looking into #753 (see last paragraph of #753 (comment)).

I was able to produce errors with ZSH_AUTOSUGGEST_MANUAL_REBIND active and sourcing a file async-widget-setup.zsh after the first precmd with the plugin active. If manual rebind is not active or if the widgets are created before the first precmd, then zsh-autosuggestions wraps the widgets and for some reason we don't seem to get any fd conflicts.

The .zshrc:

ZSH_AUTOSUGGEST_MANUAL_REBIND=true
source zsh-autosuggestions.zsh

and async-widget-setup.zsh:

function async-widget-fork() {
	exec {fd}< <(echo foo)
	zle -M "opened: $fd, autosuggest fd: $_ZSH_AUTOSUGGEST_ASYNC_FD"
}

function async-widget-read() {
	zle -M "reading from $fd: $(cat <&$fd)"
}

zle -N async-widget-fork
zle -N async-widget-read

bindkey ^A async-widget-fork
bindkey ^B async-widget-read

Then run ZDOTDIR=$PWD zsh and:

1. source async-widget-setup.zsh
2. At the next prompt, type one character e.g. "a" to trigger an async request/response cycle. This leaves _ZSH_AUTOSUGGEST_ASYNC_FD set to the stale file descriptor number.
3. Then press ^A to activate the fork. This will set the fd parameter to the same number as _ZSH_AUTOSUGGEST_ASYNC_FD.
4. Then type another character e.g. "a" to trigger an async request. This will print a "No handler installed" error and close the file descriptor pointed to by both _ZSH_AUTOSUGGEST_ASYNC_FD and fd.
5. Pressing ^B at this point will fail to read with a "bad file descriptor" error.