Fix completion for git bisect visualize #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to use the completion for git bisect visualize one currently
is greeted with the curious error of something like this:
git bisect visualize _git-bisect:89: command not found: arch
While in this case 'arch' is the name of the first folder in the
directory. The cause for this is a missing separation of switch cases
which we fix by inserting the needed ";;".
Signed-off-by: Christian Heusel <christian@heusel.eu>
christian-heusel
force-pushed
the
fix-git-bisect-visualize-completion
branch
from
7f2db37
to
833dbc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the completion for git bisect visualize one currently is greeted with the curious error of something like this:
While in this case 'arch' is the name of the first folder in the directory. The cause for this is a missing separation of switch cases which we fix by inserting the needed ";;".
In my opinion this is a potentially really nasty bug (although people are unlikely to hit it) since it executes arbitrary binaries depending on the folder the completion is used in.
See the following demonstration:
zsh-completion.mp4