-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ScheduleIteratorBuf #104
Conversation
I have a working example using this branch for those interested. The design is not tied to any async runtime, and does not require "ticking" it at regular intervals. It uses this iterator to know precisely how long to wait for the next task, while job inserts and removals interrupt and reset the sleep. use std::time::Duration;
use pop_task_scheduler::*;
use smol::Timer;
use chrono::offset::Local;
fn main() {
smol::block_on(async move {
// Creates a scheduler based on the Local timezone. Note that the `sched_service`
// contains the background job as a future for the caller to decide how to await
// it. When the scheduler is dropped, the scheduler service will exit as well.
let (mut scheduler, sched_service) = Scheduler::<Local>::launch(Timer::after);
// Creates a job which executes every 3 seconds.
let job = Job::cron("1/3 * * * * *").unwrap();
let fizz_id = scheduler.insert(job, |id| println!("Fizz"));
// Creates a job which executes every 5 seconds.
let job = Job::cron("1/5 * * * * *").unwrap();
let buzz_id = scheduler.insert(job, |id| println!("Buzz"));
// Creates a job which executes every 7 seconds.
let job = Job::cron("1/7 * * * * *").unwrap();
let bazz_id = scheduler.insert(job, |id| println!("Bazz"));
// A future which gradually drops jobs from the scheduler.
let dropper = async move {
Timer::after(Duration::from_secs(7)).await;
scheduler.remove(fizz_id);
println!("Fizz gone");
Timer::after(Duration::from_secs(5)).await;
scheduler.remove(buzz_id);
println!("Buzz gone");
Timer::after(Duration::from_secs(1)).await;
scheduler.remove(bazz_id);
println!("Bazz gone");
// `scheduler` is dropped here, which causes the sched_service to end.
};
// Poll the dropper and scheduler service concurrently until both return.
futures::future::join(sched_service, dropper).await;
});
} |
Hi, thanks for the PR! These changes look good. One superficial item: I'm not familiar with |
Sure. The convention was established with Path / PathBuf. |
Nice, thanks!
Very cool. I'm a happy Pop!_OS user, it's neat to think I'll have some of my code running on my laptop. |
Requires #103 to be merged in advance.
This adds a new
ScheduleIteratorBuf
type with a static lifetime. Which also adds anSchedule::upcoming_buf
andSchedule::after_buf
. Tests were duplicated fromScheduleIterator
, and theScheduleIterator
was improved to match the same implementation asBuf
.I need these changes to support a cron scheduling service for a distribution system updater service I'm working on. Lifetimes cause severe restrictions for use in an async context, which I would like to use to interrupt the scheduler as the scheduler receives new tasks to schedule, or is asked to remove a scheduled task.