Prepare package #1
Conversation
Confirms that the right args and kwargs are ignored on initing CurrentUserField It was confirmed that the following scenario works well: - make a model in testapp with CurrentUserField - create initial migration - create a dummy record - as sample model modification: add a model field, rename the CurrentUserField-field - create and run migration for the modification - look at dummy record, confirm that user reference is still there
…en_arguments_are_passed
| Then use it in a project:: | ||
|
|
||
| import django_currentuser | ||
| from django_currentuser.middleware import ( | ||
| get_current_user, get_current_authenticated_user) |
There was a problem hiding this comment.
@belugame I think we should have an example about using the db field too
| @@ -30,6 +30,7 @@ | |||
| } | |||
|
|
|||
| MIDDLEWARE_CLASSES = ( | |||
| 'django_currentuser.middleware.ThreadLocalUserMiddleware', | |||
There was a problem hiding this comment.
shouldn't TLUM be after the AuthMiddleware, as the later one sets the request.user attribute?
There was a problem hiding this comment.
good point, i wonder why it still works then
There was a problem hiding this comment.
notes from an offline conversation
so this works because ThreadLocalUserMiddleware.process_request sets the thread-local variable to a callable, essentially creating a closure that has a reference to request, and only when get_current_user is called is request.user evaluated. Thus as long as that method is not called between the two middlewares (TLUM and AuthenticationMiddleware), the result is OK, as we can see it in the tests.
tests/testapp/tests.py
Outdated
| try: | ||
| from unittest.mock import patch | ||
| except ImportError: | ||
| from mock import patch |
There was a problem hiding this comment.
FYI: the reason we had sixmock in the template was so we don't have to do this try/except import mechanism in the tests
tests/testapp/tests.py
Outdated
| class GetCurrentPersistedUserTestCase(TestCase): | ||
|
|
||
| def test_if_user_is_none_it_is_none(self): | ||
| self.assert_becomes(current_user=None, expected_persisted=None) |
There was a problem hiding this comment.
the name persisted is misleading to me here I think of db persistance first, not threadlocal
No description provided.