Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add app icon for macos #321

Merged
merged 1 commit into from
Jun 6, 2023
Merged

add app icon for macos #321

merged 1 commit into from
Jun 6, 2023

Conversation

mariodian
Copy link
Contributor

I propose this small change to the app's icon so it's more in line with Apple's design guidelines (added padding and shadow).

new macos icon

I left the original icon intact so the change doesn't affect Linux and Windows users.

I believe changes to window and tray in electron/index.cjs aren't necessary because:

  1. there's no window icon in any MacOS (only OSX which is fairly old)
  2. the app has no ability to be displayed in top menu bar currently (I assume that's what electron's Tray() is in MacOS)

If you want me to add the icon to window and tray though, I'm happy to do so.

ztjhz
ztjhz requested changes Jun 2, 2023
View reviewed changes
Copy link
Owner

@ztjhz ztjhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just need a new line at the end of the package.json file

package.json Outdated Show resolved Hide resolved
@ztjhz ztjhz merged commit 13ac535 into ztjhz:main Jun 6, 2023
heyFlorentin added a commit to WeMake-CX/GPT-CX that referenced this pull request Jul 4, 2023
@heyFlorentin @ayaka14732
@mariodian @ztjhz @MazeWebArchitect @akira0245 @lucaperl @Romanok2805
Update to latest Branch (#3)
bcf0bf9 
* Add woff2 web fonts

* add app icon for macos (ztjhz#321)

* clearer title generation error message

fixes ztjhz#329

* fix: title generation cost calculation

fixes ztjhz#330

* Add German translation (ztjhz#341)

* Bump v1.0.4

* Add gpt-3.5-turbo-16k model option, update gpt-3.5 prompt cost (ztjhz#351)

* add gpt-3.5-turbo-16k model option. update gpt-3.5 prompt cost

* add gpt-4-0613 models

* Update German Translation (ztjhz#348)

* Update api.json

Fixed spelling errors.

* Update drive.json

Fixed spelling errors.

* Update model.json

Fixed spelling errors.

* Add Russian translation (ztjhz#363)

* translate about.json

* translate api.json

* translate drive.json

* Add Russian language

* translate main.json

* translate model.json

* ci: add Azure Static Web Apps workflow file
on-behalf-of: @Azure opensource@microsoft.com

* Fix translation

* Fix translation

* Delete azure-static-web-apps-witty-plant-0f8ec9803.yml

* author name not translated

* fix menubar icon size in macOS (ztjhz#360)

add support for MacOS theme (light/dark)

* consistent enter to submit for new and edit message

fixes ztjhz#255, fixes ztjhz#379

---------

Co-authored-by: Ayaka Mikazuki <ayaka@mail.shn.hk>
Co-authored-by: Mario Dian <mariodian@gmail.com>
Co-authored-by: Jing Hua <tohjinghua123@gmail.com>
Co-authored-by: Matthias Held <mheld.github@held.codes>
Co-authored-by: akira0245 <33274390+akira0245@users.noreply.github.com>
Co-authored-by: lucaperl <52839381+lucaperl@users.noreply.github.com>
Co-authored-by: Romanok2805 <37216910+Romanok2805@users.noreply.github.com>
heyFlorentin added a commit to WeMake-CX/GPT-CX that referenced this pull request Jul 16, 2023
@heyFlorentin @ayaka14732
@mariodian @ztjhz @MazeWebArchitect @akira0245 @lucaperl @Romanok2805 @joshbla @Ranhiru
Update (#4)
e4c507b 
* Add woff2 web fonts

* add app icon for macos (ztjhz#321)

* clearer title generation error message

fixes ztjhz#329

* fix: title generation cost calculation

fixes ztjhz#330

* Add German translation (ztjhz#341)

* Bump v1.0.4

* Add gpt-3.5-turbo-16k model option, update gpt-3.5 prompt cost (ztjhz#351)

* add gpt-3.5-turbo-16k model option. update gpt-3.5 prompt cost

* add gpt-4-0613 models

* Update German Translation (ztjhz#348)

* Update api.json

Fixed spelling errors.

* Update drive.json

Fixed spelling errors.

* Update model.json

Fixed spelling errors.

* Add Russian translation (ztjhz#363)

* translate about.json

* translate api.json

* translate drive.json

* Add Russian language

* translate main.json

* translate model.json

* ci: add Azure Static Web Apps workflow file
on-behalf-of: @Azure opensource@microsoft.com

* Fix translation

* Fix translation

* Delete azure-static-web-apps-witty-plant-0f8ec9803.yml

* author name not translated

* fix menubar icon size in macOS (ztjhz#360)

add support for MacOS theme (light/dark)

* consistent enter to submit for new and edit message

fixes ztjhz#255, fixes ztjhz#379

* Hides default system prompt in simple mode (ztjhz#375)

* Hides default system prompt without advanced mode

* Hides default system prompt in simple mode

* Show title for when the title is too long (ztjhz#395)

---------

Co-authored-by: Ayaka Mikazuki <ayaka@mail.shn.hk>
Co-authored-by: Mario Dian <mariodian@gmail.com>
Co-authored-by: Jing Hua <tohjinghua123@gmail.com>
Co-authored-by: Matthias Held <mheld.github@held.codes>
Co-authored-by: akira0245 <33274390+akira0245@users.noreply.github.com>
Co-authored-by: lucaperl <52839381+lucaperl@users.noreply.github.com>
Co-authored-by: Romanok2805 <37216910+Romanok2805@users.noreply.github.com>
Co-authored-by: Joshua Blake Smith <jblakezsmith@gmail.com>
Co-authored-by: Jude Cooray <ranhiru@gmail.com>
heyFlorentin added a commit to WeMake-CX/GPT-CX that referenced this pull request Jul 31, 2023
@heyFlorentin @ayaka14732
@mariodian @ztjhz @MazeWebArchitect @akira0245 @lucaperl @Romanok2805 @joshbla @Ranhiru
Update (#5)
6ae5a49 
* Add woff2 web fonts

* add app icon for macos (ztjhz#321)

* clearer title generation error message

fixes ztjhz#329

* fix: title generation cost calculation

fixes ztjhz#330

* Add German translation (ztjhz#341)

* Bump v1.0.4

* Add gpt-3.5-turbo-16k model option, update gpt-3.5 prompt cost (ztjhz#351)

* add gpt-3.5-turbo-16k model option. update gpt-3.5 prompt cost

* add gpt-4-0613 models

* Update German Translation (ztjhz#348)

* Update api.json

Fixed spelling errors.

* Update drive.json

Fixed spelling errors.

* Update model.json

Fixed spelling errors.

* Add Russian translation (ztjhz#363)

* translate about.json

* translate api.json

* translate drive.json

* Add Russian language

* translate main.json

* translate model.json

* ci: add Azure Static Web Apps workflow file
on-behalf-of: @Azure opensource@microsoft.com

* Fix translation

* Fix translation

* Delete azure-static-web-apps-witty-plant-0f8ec9803.yml

* author name not translated

* fix menubar icon size in macOS (ztjhz#360)

add support for MacOS theme (light/dark)

* consistent enter to submit for new and edit message

fixes ztjhz#255, fixes ztjhz#379

* Hides default system prompt in simple mode (ztjhz#375)

* Hides default system prompt without advanced mode

* Hides default system prompt in simple mode

* Show title for when the title is too long (ztjhz#395)

* a11y button (ztjhz#335)

fixes issue ztjhz#333

---------

Co-authored-by: Ayaka Mikazuki <ayaka@mail.shn.hk>
Co-authored-by: Mario Dian <mariodian@gmail.com>
Co-authored-by: Jing Hua <tohjinghua123@gmail.com>
Co-authored-by: Matthias Held <mheld.github@held.codes>
Co-authored-by: akira0245 <33274390+akira0245@users.noreply.github.com>
Co-authored-by: lucaperl <52839381+lucaperl@users.noreply.github.com>
Co-authored-by: Romanok2805 <37216910+Romanok2805@users.noreply.github.com>
Co-authored-by: Joshua Blake Smith <jblakezsmith@gmail.com>
Co-authored-by: Jude Cooray <ranhiru@gmail.com>
Co-authored-by: Jing Hua <59118459+ztjhz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztjhz ztjhz ztjhz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariodian @ztjhz