This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
split settings into base, develop, production #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuckerruebe
reviewed
Feb 18, 2021
| 'ENGINE': 'django.db.backends.postgresql', | ||
| 'NAME': 'depot-commun', | ||
| 'USER': 'postgres', | ||
| 'PASSWORD': 'password', |
There was a problem hiding this comment.
We'll have to think about removing passwords and so on for production in the future.
There was a problem hiding this comment.
Sure. Passwords and secret key are properties that should be specified on the server. I think heroku has means to do this. That's what the heroku client library that we are using is meant for isn't it?
zuckerruebe
reviewed
Feb 18, 2021
| @@ -128,5 +127,3 @@ | |||
|
|
|||
| STATIC_URL = '/static/' | |||
|
|
|||
| django_heroku.settings(locals()) | |||
There was a problem hiding this comment.
Should we not also remove the DATABASES= part in base.py?
There was a problem hiding this comment.
yes that would make it consistent.
will you make the change or should I?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements multiple settings from #4