Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Lines : Skip Blank Lines #694

Closed
meteorquake opened this issue Jul 30, 2023 · 4 comments
Closed

Modify Lines : Skip Blank Lines #694

meteorquake opened this issue Jul 30, 2023 · 4 comments
Labels
✅enhancement 🌐i18n Localization/Internationalization ui
Milestone

Comments

@meteorquake
Copy link

meteorquake commented Jul 30, 2023

The "Modify Lines" is very useful, with its prefixing and suffixing.
Can I recommend a tickbox "Skip blank lines" as quite often you're only wanting to modify lines with content. I suppose this would be best as truly blank lines rather than also lines that are whitespace but someone may comment it would be good to include those too.
Or it could be expressed as "Include Blank Lines" with it defaulted as ticked.
I don't think it would burden the box's appearance.
David

@zufuliu zufuliu added ✅enhancement 🌐i18n Localization/Internationalization ui labels Jul 30, 2023
@zufuliu zufuliu added this to the v4.23.08 milestone Jul 30, 2023
@zufuliu
Copy link
Owner

zufuliu commented Jul 30, 2023

Added "Skip empty lines" option in 078a14a. skip empty line is easy to implement than skip blank line (line that is empty or contains only whitespaces).
image

@meteorquake
Copy link
Author

That looks great - and fantastic turnover time as ever (I will have to start a stopwatch next time!) :)

You may want to omit the trailing '.' on each option there as an aesthetic improvement? for example the Find dialog lacks them - maybe there are some other boxes similarly.

@meteorquake
Copy link
Author

meteorquake commented Jul 30, 2023

As an extra thought, it may be the 6 line number options there can be replaced by 2 boxes, one for the start number, one for the formatting, the reference to which then can always be $(N)

@zufuliu
Copy link
Owner

zufuliu commented Jul 31, 2023

it may be the 6 line number options there can be replaced by 2 boxes

Use different letters would simplify parsing (after e0ecc0f):
https://github.com/zufuliu/notepad2/blob/e0ecc0ff9dc0f1d5218becf5baa3a30c7202ac4e/src/Edit.c#L2931-L2937

@zufuliu zufuliu closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅enhancement 🌐i18n Localization/Internationalization ui
Projects
None yet
Development

No branches or pull requests

2 participants