Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Transform backslashes automatically switched on in Find/Replace Text dialogue #783

Closed
bluenlive opened this issue Apr 10, 2024 · 3 comments
Labels
Milestone

Comments

@bluenlive
Copy link

bluenlive commented Apr 10, 2024

Hello.
Thanks as always for your great programme.

When opening the Find/Replace Text dialogue in notepad2, if there is a selection, it goes like this

  1. if there is a selection, copy its contents to the string to be found
  2. if the find string contains characters such as CR, LF, etc. and is not a regular expression search, Transform backslashes is switched on

However, this causes confusion when editing ASS/SSA subtitles.

Dialogue: 0,0:00:37.49,0:00:39.93,쿄칭,,0,0,0,,{\blur4\fad(200,300)}이것은 내가...
Dialogue: 0,0:00:46.19,0:00:47.79,독백,,0,0,0,,{\blur4\fad(200,300)}이것은 내가―!
Dialogue: 0,0:00:56.22,0:00:57.78,쿄칭,,0,0,0,,{\blur4\fad(200,300)}총대장을...

This subtitle uses the \ character as a subtitle tag, as shown above, because if the user doesn't realise that the Transform backslashes is automatically on, it causes an unintended replacement.

I would like to resolve this small issue.

@zufuliu
Copy link
Owner

zufuliu commented Apr 10, 2024

Don't have a good idea to fix this, backslash in copied text will be doubled when transform backslash in on.

image

@bluenlive
Copy link
Author

Hmm...
You're right.
Backslash is added so, user can notify this situation.

I'll close this.
Thanks for kind reply.

@zufuliu
Copy link
Owner

zufuliu commented Apr 10, 2024

Should be fixed by dd82a7a, regression from ea3e54f (lpefr->bTransformBS is not reset when second copy doesn't actually transforms backslashes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants