Remove electron-localshortcut completely #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-debug hijacks the CMD/CTRL+R and reloads the whole app, whereas we only need to reload the current server. Removed those commands from electronLocalShortcuts as well as they are already registered in menu items.
This commit removes the usage of "electron-localshortcut" completely. Now, we rely on only menu accelerators for shortcuts. It's risky to register a local shortcuts in the app window either using electronLocalShortcut or globalShortcut as the registered shortcuts could interfare with OS global shortcuts which is very frustrating. This fixes #317 once and for all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of local shortcuts which is being done by
electron-localshortcut. Now the app depends on menu accelerators to register keyboard shortcuts which is the safe method. The reason we have removedelectron-localshortcutis that sometimes it hijacks the OS shortcut which is very annoying. More info about this issue can be found here - electron/electron#1334