Skip to content

Commit

Permalink
android: Disable AAPT2 for now, to unblock release builds.
Browse files Browse the repository at this point in the history
This became the default with Android Gradle Plugin version 3.0.0:
  https://developer.android.com/studio/releases/gradle-plugin#3-0-0
So turning it off returns us to the behavior before we recently
took that upgrade.

Without this line, we run into this issue when attempting to make a
release build:
  facebook/react-native#16906
That issue was closed long ago when an intended fix was merged, but
then that was reverted.  The fix went back in as da6a5e043 upstream,
which is in v0.57.0, so we'll get it when we take that upgrade;
hopefully that then fixes this for real.
  • Loading branch information
gnprice committed Oct 24, 2018
1 parent 53970d4 commit 037f6d6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,7 @@
# This option should only be used with decoupled projects. More details, visit
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true

# TODO remove this after RN 0.57 upgrade.
# See https://github.com/facebook/react-native/issues/16906 .
android.enableAapt2=false

0 comments on commit 037f6d6

Please sign in to comment.