Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topics list fail to load if opened from an offline state #2310

Open
codebu5ter opened this issue Apr 13, 2018 · 4 comments
Open

Topics list fail to load if opened from an offline state #2310

codebu5ter opened this issue Apr 13, 2018 · 4 comments
Labels
upstream: RN Issues related to an issue in React Native

Comments

@codebu5ter
Copy link
Collaborator

Steps to reproduce:

  1. Go offline.
  2. Narrow to any stream.
  3. Tap the 'bullet list' icon to go to the Topics screen.
  4. Turn on mobile data/Wi-Fi.
  5. The list of Topics fail to load even after turning on mobile data.

screenshot_20180413-223623
@codebu5ter codebu5ter changed the title Topics list fail to load if started from an offline state Topics list fail to load if opened from an offline state Apr 14, 2018
@pulkonet
Copy link
Collaborator

I think this is related to #2287 .

@codebu5ter
Copy link
Collaborator Author

@pulkonet That issue is similar, but since this deals with the display of topics while that issue deals with the display of messages, I think both need separate issues.

@pulkonet
Copy link
Collaborator

You're right, but I stated the relation just so that anyone trying to fix it could take reference.

@pulkonet pulkonet mentioned this issue Apr 15, 2018
Open
codebu5ter added a commit to codebu5ter/zulip-mobile that referenced this issue Apr 16, 2018
@codebu5ter
topics: Fix failure to load from offline state.
e069bf1 
This fix first checks for the online status in TopicListScreen, and if
found to be online, renders TopicList, which houses all the Redux logic
and the call to Selectors that were originally in TopicListScreen.

Fixes zulip#2310
@codebu5ter codebu5ter mentioned this issue Apr 16, 2018
Closed
@roberthoenig
Copy link
Contributor

Hmm, this issue seems to involve two bugs: One bug is the RN fetch() bug that causes #2287. But even if that bug was resolved, I think this issue would still be valid, since it is about narrowing to a topic while the device is offline and coming back online afterwards. Right now, I don't think we resend requests that have been made while offline. In any case, we probably have to wait until facebook/react-native#19709 gets resolved.

@gnprice gnprice added the upstream: RN Issues related to an issue in React Native label Jun 14, 2018
This was referenced Jun 21, 2018
Open
Closed
This was referenced Feb 21, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream: RN Issues related to an issue in React Native
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

topics: Fix failure to load from offline state. codebu5ter/zulip-mobile
4 participants
@gnprice @roberthoenig @codebu5ter @pulkonet