Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group chat screen nav bar is broken when there are many members in the chat. #3700

Open
jainkuniya opened this issue Nov 23, 2019 · 2 comments · May be fixed by #4069
Open

Group chat screen nav bar is broken when there are many members in the chat. #3700

jainkuniya opened this issue Nov 23, 2019 · 2 comments · May be fixed by #4069
Labels
a-navigation

Comments

@jainkuniya
Copy link
Member

Screenshot_20191124-032042
@jainkuniya jainkuniya changed the title Group chat screen is broken when there are many members in the chat. Group chat screen nav bar is broken when there are many members in the chat. Nov 23, 2019
@awasthishubh
Copy link
Contributor

@zulipbot claim

@gnprice gnprice mentioned this issue Jan 10, 2020
Closed
@awasthishubh awasthishubh mentioned this issue Jan 10, 2020
Closed
@chrisbobbe chrisbobbe mentioned this issue Mar 5, 2020
Closed
@Maskedman99
Copy link
Contributor

Screenshot-20200417025912-339x222

It's also broken when the recipient's name is large.

Maskedman99 added a commit to Maskedman99/zulip-mobile that referenced this issue Apr 25, 2020
@Maskedman99
group-pm: Fix breaking of navbar when there is a large no.of recipients
8e6bca9 
With large number of recipients in group-pm the navbar overflows with
avatars. This is fixed by displaying the avatars in a Flatlist which hides
the overflow effectively by letting users scroll through the avatars, while
also providing the memory enhancements that are needed with the large
data.

Fixes: zulip#3700.
@Maskedman99 Maskedman99 linked a pull request Apr 25, 2020 that will close this issue
Open
im-adithya added a commit to im-adithya/zulip-mobile that referenced this issue Mar 7, 2021
@im-adithya
Navigation: Update nav to use ScrollView.
305299d 
Updates TitleGroup to use ScrollView instead
of View so that the avatars in nav bar don't
overflow and can be scrolled to view

Fixes zulip#3700
@im-adithya im-adithya mentioned this issue Mar 7, 2021
Open
im-adithya added a commit to im-adithya/zulip-mobile that referenced this issue Mar 7, 2021
@im-adithya
Navigation: Update nav to use ScrollView.
d96db73 
Updates TitleGroup to use ScrollView instead
of View so that the avatars in nav bar don't
overflow and can be scrolled to view

Fixes zulip#3700
im-adithya added a commit to im-adithya/zulip-mobile that referenced this issue Mar 12, 2021
@im-adithya
Navigation: Update nav to use ScrollView.
fdb75c9 
Updates TitleGroup to use ScrollView instead
of View so that the avatars in nav bar don't
overflow and can be scrolled to view

Fixes zulip#3700
@im-adithya im-adithya mentioned this issue Mar 14, 2021
Open
im-adithya added a commit to im-adithya/zulip-mobile that referenced this issue Mar 18, 2021
@im-adithya
Navigation: Update nav to use ScrollView.
49a8bd8 
Updates TitleGroup to use ScrollView instead
of View so that the avatars in nav bar don't
overflow and can be scrolled to view

Fixes: zulip#3700
im-adithya added a commit to im-adithya/zulip-mobile that referenced this issue Mar 18, 2021
@im-adithya
Navigation: Update nav to use ScrollView.
6a7ac21 
Updates TitleGroup to use ScrollView instead
of View so that the avatars in nav bar don't
overflow and can be scrolled to view

Fixes: zulip#3700
im-adithya added a commit to im-adithya/zulip-mobile that referenced this issue Apr 2, 2021
@im-adithya
Navigation: Update nav to use ScrollView.
3cd6768 
Updates TitleGroup to use ScrollView instead
of View so that the avatars in nav bar don't
overflow and can be scrolled to view

Fixes: zulip#3700
im-adithya added a commit to im-adithya/zulip-mobile that referenced this issue Apr 6, 2021
@im-adithya
Navigation: Update nav to use ScrollView.
725d29e 
Updates TitleGroup to use ScrollView instead of View
so that the avatars in nav bar don't overflow and can
be scrolled to view.

Fixes: zulip#3700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-navigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

group-pm: Fix breaking of navbar when there is a large no.of recipients Maskedman99/zulip-mobile
4 participants
@jainkuniya @chrisbobbe @Maskedman99 @awasthishubh