Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios: Drop iOS 11 support; require iOS 12.1+. #4664

Merged
merged 2 commits into from
Apr 20, 2021
Merged

ios: Drop iOS 11 support; require iOS 12.1+. #4664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da269e9
ios: Drop iOS 11 support; require iOS 12.1+.
chrisbobbe Apr 15, 2021
7336fb1
docs [nfc]: Remind about `developer-guide` when dropping platform ver…
chrisbobbe Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/architecture/platform-versions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,16 @@ History:
* We dropped iOS 10 support in 2020-10. It was 0.3% of iOS users who
tried Zulip, and we wanted to use a feature introduced in iOS 11,
called "named colors".
* We [dropped iOS 11 support] in 2021-04. It was 0.1% of iOS users
who tried Zulip. We started iOS 12 support at 12.1 because Xcode's
dropdown for "Deployment Target" didn't have a 12.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here like:

<!-- When updating this, please update `docs/developer-guide.md` as well. -->

Alternatively, we might want to consider just having fewer places where we keep this information :) I'd be fine with removing it from docs/developer-guide.md altogether, or keeping a link to this doc but not explicitly writing down the versions.

<!-- When updating this, please update `docs/developer-guide.md` as well. -->

[dropped-android-j]: https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/625585
[dropped iOS 8 support]: https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/628412
[dropped iOS 9 support]: https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/771761
[dropped-android-k]: https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/794551
[dropped iOS 11 support]: https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1165087


Related observations:
Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Developer guide

We target operating systems >= Android 5 Lollipop (API 21)
and >= iOS 11.0. (Details [here](architecture/platform-versions.md).)
and >= iOS 12.1. (Details [here](architecture/platform-versions.md).)

## Why React Native?

Expand Down
2 changes: 1 addition & 1 deletion ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This should match the iOS Deployment Target
# (project > ZulipMobile > Info in Xcode)
platform :ios, '11.0'
platform :ios, '12.1'

require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
Expand Down
2 changes: 1 addition & 1 deletion ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,6 @@ SPEC CHECKSUMS:
Yoga: 4bd86afe9883422a7c4028c00e34790f560923d6
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: 0eb2bf1b0f7972fc7183f5eac73708f76355c614
PODFILE CHECKSUM: 46ba24e5bbaf52d511ae0e860a6c332e11c21c0b

COCOAPODS: 1.10.1
4 changes: 2 additions & 2 deletions ios/ZulipMobile.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
HEADER_SEARCH_PATHS = "";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.1;
LD_RUNPATH_SEARCH_PATHS = "/usr/lib/swift $(inherited)";
LIBRARY_SEARCH_PATHS = (
"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",
Expand Down Expand Up @@ -546,7 +546,7 @@
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
HEADER_SEARCH_PATHS = "";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.1;
LD_RUNPATH_SEARCH_PATHS = "/usr/lib/swift $(inherited)";
LIBRARY_SEARCH_PATHS = (
"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",
Expand Down
4 changes: 2 additions & 2 deletions src/webview/js/js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import { toggleSpoiler } from './spoilers';
*
* * (When updating these, be sure to update tools/generate-webview-js too.)
*
* * We support iOS 11. So this code needs to work on Mobile Safari 11.
* Graceful degradation is acceptable below iOS 13 / Mobile Safari 13.
* * We support iOS 12. So this code needs to work on Mobile Safari 12.
* Graceful degradation is acceptable below iOS 14 / Mobile Safari 14.
*
* * For Android, core functionality needs to work on Chrome 44.
* Graceful degradation is acceptable below Chrome 74.
Expand Down
2 changes: 1 addition & 1 deletion tools/generate-webview-js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const targetPlatforms = {
// Babel does distinguish `safari` (meaning on macOS, I guess) from `ios`.
// Some features arrive in e.g. "safari 11.1" but "ios 11.3", or in
// 13.1 vs 13.4, so the distinction is still relevant.
ios: 11,
ios: 12,
};

// Disable the default react-native transformations.
Expand Down