Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slide animation view. #682

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Add slide animation view. #682

merged 1 commit into from
Jun 12, 2017

Conversation

Sam1301
Copy link
Member

@Sam1301 Sam1301 commented Jun 12, 2017

Added a slide animation view which will also help lightbox.

@Sam1301 Sam1301 force-pushed the slide-animation branch 2 times, most recently from a4e0490 to 3a64d0b Compare June 12, 2017 09:43
@borisyankov
Copy link
Contributor

Looks good.
We might want to use some of the built-in functionality in React Navigation for the lightbox though.
Merging this in.

@borisyankov borisyankov merged commit 75f0646 into zulip:master Jun 12, 2017
@Sam1301
Copy link
Member Author

Sam1301 commented Jun 12, 2017 •
edited
Loading

makes sense 👍 I was looking forward to use this animation for header and footer of lightbox, whenever the user taps the image. For the scene transition to lightbox, it probably makes sense to have a shared element animation, where the shared element would be the image between two screens - main and lightbox. This is probably not yet implemented in react navigation. So, maybe we could use react-navigation/react-navigation#941 in the meantime or fallback to a default animation?

@Sam1301 Sam1301 deleted the slide-animation branch June 12, 2017 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sam1301 @borisyankov @zulipbot