Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current Terminal size added in About popup #1540

Closed
wants to merge 2 commits into from
Closed

Current Terminal size added in About popup #1540

wants to merge 2 commits into from

Conversation

Swarnim114
Copy link
Collaborator

closes #1536

What does this PR do, and why?

Adds a Terminal size label under the "Detected Environment " in About popup

image

External discussion & connections

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

Visual changes

image

@zulipbot zulipbot added the size: S [Automatic label added by zulipbot] label Aug 1, 2024
@Swarnim114
Copy link
Collaborator Author

@zulipbot label "PR needs review"

@zulipbot zulipbot added the PR needs review PR requires feedback to proceed label Aug 1, 2024
@Swarnim114
Copy link
Collaborator Author

Hi @neiljp,

Sorry for the mess-up in that PR earlier. I'm new to open source development. Thanks for your understanding, and please continue guiding me.

@zulipbot zulipbot added the PR ready to be merged PR has been reviewed & is ready to be merged label Aug 2, 2024
@Swarnim114 Swarnim114 closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsashank rsashank Awaiting requested review from rsashank

Assignees
No one assigned
Labels
PR needs review PR requires feedback to proceed PR ready to be merged PR has been reviewed & is ready to be merged size: S [Automatic label added by zulipbot]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add current terminal window size to About popup
4 participants
@Swarnim114 @rsashank @zulipbot @neiljp