requirements: Upgrade boto to boto3 #3706
Conversation
|
Automated message from Dropbox CLA bot @sinwar, it looks like you've already signed the Dropbox CLA. Thanks! |
requirements/common.txt
Outdated
| @@ -26,6 +26,10 @@ backports.ssl-match-hostname==3.5.0.1 | |||
|
|
|||
| # Needed for S3 file uploads | |||
| boto==2.45.0 | |||
| boto3==1.4.4 | |||
There was a problem hiding this comment.
we require boto because there is still no equivalent of boto.utils.get_instance_metadata() in boto3.
boto/boto3#313
sinwar
force-pushed
the
botoupgrade
branch
2 times, most recently
from
d6da3da
to
1a54637
Compare
| @@ -26,6 +26,10 @@ backports.ssl-match-hostname==3.5.0.1 | |||
|
|
|||
| # Needed for S3 file uploads | |||
| boto==2.45.0 | |||
| botocore==1.5.7 | |||
There was a problem hiding this comment.
we require boto because there is still no equivalent of boto.utils.get_instance_metadata() in boto3.
boto/boto3#313
| # in situations where buckets don't exist, but that shouldn't be | ||
| # an issue for us.) | ||
| bucket = conn.get_bucket(bucket_name, validate=False) | ||
| return bucket |
There was a problem hiding this comment.
What's the story with removing this comment?
There was a problem hiding this comment.
http://boto3.readthedocs.io/en/latest/guide/migrations3.html#accessing-a-bucket
boto3 doesn't automatically validate whether a bucket exists so in normal calls validate will be false and for validation we have to check manually as mentioned in above link.
|
@sinwar huge thanks for working on this, and sorry for the very delayed review! I've been slow to review this I think because I'm worried about it potentially breaking things, because we don't have a good way to test the boto setup not in the production (only half of the existing As a path forward, would you be up for working on bringing the test coverage for I think it'd be a good experience for you, the test coverage is highly valuable independent of this PR, and I think once we did that, merging this would be a lot less scary :). |
|
@timabbott I will be up for this now but I haven't decide my GSoC proposal idea and I want to make a good proposal from now. I want to work with python, Django area. Can you suggest me any guidance for this so I can confidently do other work. |
|
Yeah, let's chat about GSoC on chat.zulip.org when convenient. |
|
Hello @sinwar, a Zulip maintainer reviewed this pull request over a week ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly. Thank you for your valuable contributions to Zulip! |
|
Heads up @sinwar, we just merged some commits (latest: 510b7a0) that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
@sinwar can you rebase and update this PR? It'd be nice to merge it soon. |
|
Hello @sinwar, a Zulip maintainer reviewed this pull request over a week ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly. Thank you for your valuable contributions to Zulip! |
1 similar comment
|
Hello @sinwar, a Zulip maintainer reviewed this pull request over a week ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly. Thank you for your valuable contributions to Zulip! |
|
Heads up @sinwar, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Hello @sinwar, a Zulip maintainer reviewed this pull request over a week ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly. Thank you for your valuable contributions to Zulip! |
|
Hello @sinwar, a Zulip maintainer reviewed this pull request over 7 days ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly. Thank you for your valuable contributions to Zulip! |
|
Heads up @sinwar, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Heads up @sinwar, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Hello @sinwar, a Zulip maintainer reviewed this pull request over 10 days ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly. Thank you for your valuable contributions to Zulip! |
|
Hello @sinwar, a Zulip maintainer reviewed this pull request over 10 days ago, but you haven't updated your pull request since. Please take a look at the requested changes and update your pull request accordingly. Thank you for your valuable contributions to Zulip! |
|
Closing this due to long inactivity. |
Fixes #3490