Capital Module Rework/Minor edits to Sub-cap Modules #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Bulwark and Repair Field now don't loop to provide extra healing, They also fixed Visual Timers. Changed: All Capital Ship Modules lie in their own category in the Engineering Bench. Targeting Array - No longer gives Damage Boost (see Weapons Computer) instead of evasion decrease it is now damage. Advanced Thrusters - No Value Changes here, just a description edit. Reinforced Plating - No longer gives evasion decrease, but does decrease shields instead. Quad Lasers: Adjusted oversized Fire Range and increase capacitor costs. Turbolasers: Increased Damage from Module Bonus. Laser Cannon Battery: Adjusted Range and Damage. (Slight increase on NPC Damages. Beam Cannon/Laser Cannon: Adjusted Ranges and Cap Costs. Bulwark/Repair Field - Both now heal larger amounts to cover for single use fire mechanics opposed to original design. Missile Weapons - Adjusted the "minimum shield value" to 10. Capital Ship Configuration Changes - Scaling for Hull/Shields Increased Overall. Warship - No Longer gains Damage Bonus. Slight increase in Armor values and health boost. But Gains Accuracy Increase. Logistics - Small Shield Increase and Armor Increase. Skirmisher - Lost Accuracy Increase, Gained Damage Increase and larger shield Pool. Added: Weapons Computer - Increased Damage for Lower Accuracy Power Diverter - Lower Cap for Faster shield recharge E-War Module - Generates Enmity https://docs.google.com/spreadsheets/d/1g0DB4i-zY4bQQzifilb1OrbiFn28FHK5Zg_29RxK4Yo/edit?usp=sharing
Changed from Damage to Attack to align with rest of modules.
Changed Desc for uniformity.
Whoopsie
zunath
reviewed
Sep 15, 2024
| .Name(name) | ||
| .ShortName(shortName) | ||
| .Texture("iit_ess_252") | ||
| .Description("This weapons computer increases all Attack by 20 but reduce Accuracy by 10.") |
zunath
reviewed
Sep 15, 2024
| @@ -130,6 +130,8 @@ public enum RecipeCategoryType | |||
| SpecialSubmissionItems = 60, | |||
| [RecipeCategory("Starship Ammo", true)] | |||
| StarshipAmmo = 61, | |||
| [RecipeCategory("Capital Module Recipes", true)] | |||
| CapitalShipModule =62, | |||
There was a problem hiding this comment.
space between the equals and the 62
zunath
reviewed
Sep 15, 2024
| @@ -2502,6 +2502,11 @@ public enum RecipeType | |||
| CorvetteJehaveyFrigate = 4794, | |||
|
|
|||
There was a problem hiding this comment.
you don't need a gap of empty space here
zunath
reviewed
Sep 15, 2024
| public MigrationExecutionType ExecutionType => MigrationExecutionType.PostCacheLoad; | ||
| public void Migrate() | ||
| { | ||
| RecalculateAllShipStats(); |
There was a problem hiding this comment.
Please confirm this recalc works and we won't run into the same problem as last time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Bulwark and Repair Field now don't loop to provide extra healing, They also fixed Visual Timers.
Changed:
All Capital Ship Modules lie in their own category in the Engineering Bench.
Targeting Array - No longer gives Attack Boost (see Weapons Computer) instead of evasion decrease it is now damage.
Advanced Thrusters - No Value Changes here, just a description edit.
Reinforced Plating - No longer gives evasion decrease, but does decrease shields instead.
Quad Lasers: Adjusted oversized Fire Range and increase capacitor costs.
Turbolasers: Increased Damage from Module Bonus.
Laser Cannon Battery: Adjusted Range and Damage. (Slight increase on Lower-End Boss Damages.)
Beam Cannon/Laser Cannon: Adjusted Ranges and Cap Costs.
Bulwark/Repair Field - Both now heal larger amounts to cover for single use fire mechanics opposed to original design.
Missile Weapons - Adjusted the "minimum shield value" to 10.
Capital Ship Configuration Changes -
Scaling for Hull/Shields Increased Overall.
Warship - No Longer gains Attack Bonus. Slight increase in Armor values and health boost. But Gains Accuracy Increase. Logistics - Small Shield Increase and Armor Increase. Skirmisher - Lost Accuracy Increase, Gained Attack Increase and larger shield Pool.
Added:
Weapons Computer - Increased Damage for Lower Accuracy Power Diverter - Lower Cap for Faster shield recharge E-War Module - Generates Enmity
https://docs.google.com/spreadsheets/d/1g0DB4i-zY4bQQzifilb1OrbiFn28FHK5Zg_29RxK4Yo/edit?usp=sharing