Improved interface for split_by_token #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `split_by_token_ordinary` method and its corresponding iterator `split_by_token_ordinary_iter` have been added to the `CoreBPE` struct in `vendor_tiktoken.rs`. These methods allow for ordinary tokenization of a string without special tokens from the BPE model. Simplified the .split_by_token_with_special_tokens method to just be `split_by_token` and differentiated between methods that return iter vs collection.
|
I thought about this some more - I think this interface is more in line with the rest of the codebase. |
zurawiki
approved these changes
Apr 24, 2023
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
split_by_token_ordinarymethod and its corresponding iteratorsplit_by_token_ordinary_iterhave been added to theCoreBPEstruct invendor_tiktoken.rs. These methods allow for ordinary tokenization of a string without special tokens from the BPE model.Simplified the .split_by_token_with_special_tokens method to just be
split_by_tokenand differentiated between methods that return iter vs collection.