Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md to package #22

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add README.md to package #22

merged 1 commit into from
Jun 20, 2023

Conversation

fiji-flo
Copy link
Contributor

The missing README.md breaks vendored builds depending on tiktoken-rs.

In any project using tikoken-rs do:

mkdir .cargo
cargo vendor > .cargo/config
cargo build --release

...

error: couldn't read /tmp/my-project-vendored/vendor/tiktoken-rs/src/../README.md: No such file or directory (os error 2)
 --> /tmp/my-project-vendored/vendor/tiktoken-rs/src/lib.rs:1:10
  |
1 | #![doc = include_str!("../README.md")]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in the macro `include_str` (in Nightly builds, run with -Z macro-backtrace for more info)

@zurawiki
Copy link
Owner

Thanks for the patch. Repros locally and can confirm the fix

@zurawiki zurawiki closed this Jun 20, 2023
@zurawiki zurawiki reopened this Jun 20, 2023
@zurawiki zurawiki merged commit 9db9576 into zurawiki:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants