fix(deps): update rust crate rustc-hash to v2 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/rustc-hash-2.x
branch
from
edcae0c to
56fa958
Compare
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Jan 13, 2025
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Jan 13, 2025
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jan 13, 2025
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
facebook-github-bot
pushed a commit
to facebook/errpy
that referenced
this pull request
Jan 13, 2025
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
facebook-github-bot
pushed a commit
to facebook/buck2-shims-meta
that referenced
this pull request
Jan 13, 2025
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 13, 2025
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jan 13, 2025
Summary: To 2.1 Unfortunately, I can't remove the old version of the crate. The problem is that it appears in the [public API](https://docs.rs/tiktoken-rs/latest/tiktoken_rs/struct.CoreBPE.html#method.new) of `tiktoken_rs`, which we also import. That crate has a PR to upgrade its dependency [here](zurawiki/tiktoken-rs#95) but that has not been merged. Alternatives here are: 1. Fork `tiktoken_rs`. This seems worse. 2. It's strictly speaking possible to use generics combined with some other tricks to avoid needing to name v1 of `FxHashMap` in fbsource. However, that makes that code extraordinarily hard to change and work with, and doesn't seem all that clearly motivated. If there's something else I should be doing here, all ears Reviewed By: zertosh Differential Revision: D68064854 fbshipit-source-id: bd1c96abbc0ebaa178a55826bc85c61eb35e8301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.1.0->2.0.0Release Notes
rust-lang/rustc-hash (rustc-hash)
v2.1.0Compare Source
CloneforFxRandomStateCloneforFxSeededStatev2.0.0Compare Source
This replaces the previous "fxhash" algorithm originating in Firefox
with a custom hasher designed and implemented by Orson Peters (
@orlp).It was measured to have slightly better performance for rustc, has better theoretical properties
and also includes a significantly better string hasher.
no_stdbuildsv1.2.0Note: This version has been yanked due to issues with the
no_stdfeature!FxBuildHasherunit structFxRandomStatebased onrand(behind therandfeature) for random seedsconst fnCloneforFxHasherstructConfiguration
📅 Schedule: Branch creation - "* * 1 */3 *" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.