Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

Dyanmic Icon Injection #342

Closed
myqroft opened this issue Dec 18, 2014 · 6 comments
Closed

Dyanmic Icon Injection #342

myqroft opened this issue Dec 18, 2014 · 6 comments

Comments

@myqroft
Copy link

myqroft commented Dec 18, 2014

Hey Guys,

Great work with the new framework, I'm having a lot of fun playing with it.

I was curious if there was a workaround for dynamically injected iconic icons? I can't seem to get them to load when I inject them after the page loads.

What am I missing?

@AntJanus
Copy link
Contributor

As long as you use the Iconic directive, it should work as described. Are your icons showing up when they're not dynamically injected?

@myqroft
Copy link
Author

myqroft commented Dec 18, 2014

They are.

To be clear, I'm using ng-repeat on an li to create a nav menu, and am using {{item.url}}, {{item.name}}, and am trying to use {{item.icon}} to output the name of the icon into the data-src.

eg. < img zf-iconic="" data-src="bower_components/foundation-apps/iconic/{{item.icon}}.svg" class="iconic-md" >

(This is all currently taking place within the home.html partial)

@AntJanus
Copy link
Contributor

Hmm.. that's an interesting use case. I'll open up a PR for Iconic to allow dynamic injection.

@myqroft
Copy link
Author

myqroft commented Dec 18, 2014

Sweet! Glad I didn't waste your time. :) Also, thanks for your video, 'twas helpful in getting me started.

@AntJanus
Copy link
Contributor

Look out for another this weekend! Thank you! :)

@myqroft
Copy link
Author

myqroft commented Dec 18, 2014

Sweet! I look forward to it!

I'll keep trying to tackle this and see if I can come up with a solution worth submitting a PR for.

akiran pushed a commit to akiran/foundation-apps that referenced this issue Dec 19, 2014
akiran pushed a commit to akiran/foundation-apps that referenced this issue Dec 19, 2014
AntJanus added a commit that referenced this issue Dec 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants