Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

grid-orient uses vertical/horizontal alignment parameters not true/false #212

Merged
merged 4 commits into from
Dec 11, 2014
Merged

grid-orient uses vertical/horizontal alignment parameters not true/false #212

merged 4 commits into from
Dec 11, 2014

Conversation

gabysbrain
Copy link
Contributor

Since grid-orient uses vertical or horizontal to detect what to do you can't pass true/false and get vertical alignment. Another option would be to change the acceptable values for the parameter to grid-frame and grid-block

@gakimball
Copy link
Contributor

I think that would be a better option, changing the $orientation parameter of the grid-frame and grid-block mixins. The default should be horizontal to match how the class system works.

If you'd like to make the change I can merge it in :)

@gabysbrain
Copy link
Contributor Author

Sure, that's easy to change. However, the parameter is called $direction in grid-orient. Shouldn't the parameter name be consistent across the 3 mixins? Would you prefer $orientation or $direction?

@gakimball
Copy link
Contributor

Ah yeah, good catch. Let's say $orientation, because that same term is used for menu bar and tabs as well.

@gabysbrain
Copy link
Contributor Author

ok, sounds good.

@gakimball gakimball added this to the 1.0.1 milestone Dec 11, 2014
@gakimball
Copy link
Contributor

Awesome, thanks!

gakimball added a commit that referenced this pull request Dec 11, 2014
grid-orient uses vertical/horizontal alignment parameters not true/false
@gakimball gakimball merged commit 10e2cbc into zurb:master Dec 11, 2014
@rafibomb
Copy link
Contributor

@gabysbrain Thanks! email foundation at zurb .com for some sweet Yeti stickers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants