Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

Gulpfile refactor #296

Merged
merged 6 commits into from
Dec 12, 2014
Merged

Gulpfile refactor #296

merged 6 commits into from
Dec 12, 2014

Conversation

gakimball
Copy link
Contributor

We just reorganized the Gulpfile used in the template stack, so let's do that here, and then some. Here's what's up:

  • Organized the Gulpfile into categories (files, Sass, JavaScript, etc.)
  • Added comments for every task
  • Renamed the tasks to all use a similar naming scheme
  • Upgraded to gulp-ruby-sass 1.0 alpha
  • Separated framework JavaScript from docs-specific code
    • Framework code is compiled to foundation.js
    • Docs code is compiled to app.js
  • Added a task to deploy compiled JS and Sass to our server, where it will be picked up by a CDN

It seems to pretty much work, although I get this error in the documentation:

 Error: [ng:areq] Argument 'DefaultController' is not a function, got undefined
http://errors.angularjs.org/1.3.5/ng/areq?p0=DefaultController&p1=not%20aNaNunction%2C%20got%20undefined
    at http://localhost:8080/assets/js/foundation.js:5:654
    at assertArg (http://localhost:8080/assets/js/foundation.js:5:12013)
    at assertArgFn (http://localhost:8080/assets/js/foundation.js:5:12215)
    at http://localhost:8080/assets/js/foundation.js:7:9848
    at http://localhost:8080/assets/js/foundation.js:15:4165
    at invokeLinkFn (http://localhost:8080/assets/js/foundation.js:7:4672)
    at nodeLinkFn (http://localhost:8080/assets/js/foundation.js:6:22977)
    at compositeLinkFn (http://localhost:8080/assets/js/foundation.js:6:12817)
    at http://localhost:8080/assets/js/foundation.js:6:11488
    at updateView (http://localhost:8080/assets/js/foundation.js:15:2951)

Leftover things:

  • Move arrays of file paths (especially the JavaScript imports) into their own variable, to be shared by the javascript and deploy:cdn tasks
  • Get up from my desk and ask somebody for help setting up the directory for the CDN

@gakimball gakimball added this to the 1.0.1 milestone Dec 12, 2014
@akiran
Copy link
Contributor

akiran commented Dec 12, 2014

Adding template cache will further cleanup the build process #298

@akiran
Copy link
Contributor

akiran commented Dec 12, 2014

Check this pull request to foundation-apps-template

@AntJanus
Copy link
Contributor

@gakimball I keep getting an error when running Gulp:

Error: app.scss:1:1: Unclosed block

AntJanus added a commit that referenced this pull request Dec 12, 2014
@AntJanus AntJanus merged commit a839fe2 into master Dec 12, 2014
@AntJanus AntJanus deleted the gulpfile branch December 12, 2014 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants