Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jQuery noconflict #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix jQuery noconflict #28

wants to merge 1 commit into from

Conversation

Kekke88
Copy link

@Kekke88 Kekke88 commented Mar 19, 2014

I had a problem with my Joomla site that throw a conflict error.

I had a problem with my Joomla site that throw a conflict error.
@nikolov-tmw
Copy link

I can confirm that the same issue exists with WordPress sites.

In my case I didn't have to change lines 19 to 21 - I only changed the first line to jQuery(document).ready(function($) {

Unless I'm wrong, I don't see a reason to change $ to jQuery for lines 19 to 21 - it's all wrapped in the jQuery(document).ready() call which gets jQuery as it's argument.

@pronebird
Copy link

I cannot even try it because of that.

NicholasRBowers added a commit to NicholasRBowers/responsive-tables that referenced this pull request Apr 15, 2015
@joelpittet
Copy link

Wrap in closure?

(function($, window, document) {
 // $ stuff here
})(jQuery, window, document);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants