Fix external menu trigger.

zurb · Aug 23, 2017 · 38c6707 · 38c6707
1 parent d796200
commit 38c6707
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/dist/tribute.js b/dist/tribute.js
diff --git a/dist/tribute.min.js b/dist/tribute.min.js
diff --git a/dist/tribute.min.js.map b/dist/tribute.min.js.map
diff --git a/src/Tribute.js b/src/Tribute.js
@@ -266,6 +266,7 @@ class Tribute {
         }
 
         this.current.collection = this.collection[collectionIndex || 0]
+        this.current.externalTrigger = true
         this.current.element = element
 
         this.insertTextAtCursor(this.current.collection.trigger)

diff --git a/src/TributeEvents.js b/src/TributeEvents.js
@@ -71,7 +71,10 @@ class TributeEvents {
             }
             tribute.selectItemAtIndex(li.getAttribute('data-index'), event)
             tribute.hideMenu()
-        } else if (tribute.current.element) {
+
+        // TODO: should fire with externalTrigger and target is outside of menu
+        } else if (tribute.current.element && !tribute.current.externalTrigger) {
+            tribute.current.externalTrigger = false
             setTimeout(() => tribute.hideMenu())
         }
     }