Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability for Tribute to work as autocomplete 🕺 #197

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

MrRobz
Copy link
Contributor

@MrRobz MrRobz commented Feb 8, 2019

These changes allow Tribute to work as an autocomplete type-head that gives suggestions as you type.
tribute-autocomplete

How to make tribute work as autocomplete:
passautocompleteMode: true with the rest of the Tribute configs

some points to note:

  1. autocomplete mode currently does not work with collections as there is no multiple trigger points
  2. when mention text is empty around cursor, it shows all the menu item. (maybe we could passing another option: shouldShowResultsForNull)

src/Tribute.js Show resolved Hide resolved
src/Tribute.js Show resolved Hide resolved
@MrRobz MrRobz changed the title Tribute add autocomplete options Ability for Tribute to work as autocomplete 🕺 Feb 8, 2019
@mrsweaters
Copy link
Collaborator

Everything seems to be working as intended and the code looks good! Thanks for the great work!

@mrsweaters mrsweaters merged commit ad75f57 into zurb:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants