Add more info to the tribute-replaced event detail #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those two variables are poorly named within tribute and are ripe for a refactor. What if we renamed context to instance and info to context? |
|
Hi @mrsweaters, Can be. I'll update it in the coming days. |
andreynering
force-pushed
the
add-more-info-to-the-tribute-replaced-event
branch
from
a6e61b5
to
c54155a
Compare
|
@mrsweaters Done! I also moved some variable declarations to inside the |
|
This looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
It's often useful having access on more information on this event. I specially need to know the trigger char here, since you can have multiple triggers enabled.
Also, I think it'd be nice to have access to the collection itself, too.