Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable skip local search when user wants server side to execute the filtering #271

Merged
merged 6 commits into from
Jun 14, 2019
Merged

Conversation

onhate
Copy link
Contributor

@onhate onhate commented Jun 6, 2019

With the addition of a new searchOpts.skip property it enables the user to skip the local filtering, this is very handy when using a server side that executes the search and filtering and in this case tribute is just the render engine for the data.

new Tribute({ searchOpts: { skip: true } });

@onhate
Copy link
Contributor Author

onhate commented Jun 12, 2019

@mrsweaters any thoughts on this subject?

@mrsweaters
Copy link
Collaborator

This looks great and makes total sense. Could you add a test for this functionality?

@onhate
Copy link
Contributor Author

onhate commented Jun 14, 2019

@mrsweaters done!

@mrsweaters
Copy link
Collaborator

Thanks @onhate!

@mrsweaters mrsweaters merged commit 1acf0dd into zurb:master Jun 14, 2019
@hamsterbacke23
Copy link

Thanks for implementing it, could this be added to the documentation, I looked forever for a way to do this.

@mrsweaters
Copy link
Collaborator

@hamsterbacke23 Good point, updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants