Add support for multi-character triggers #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like an incredible feature, and thank you for updating the test suite. The PR looks good! Merging. |
|
@peschuster Could you do a separate PR to update the readme? |
|
@peschuster Massive thanks to you for getting this feature across the line. I'm so happy it's in there now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of PR #230 with additional tests.
It adds support for triggers with multiple characters (e.g. "$(" or "{{").
This enables tribute to be used for more than traditional "@mentions".
Let me know if there is anything else I can do to help integrating this feature.