Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit input event #363

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Emit input event #363

merged 2 commits into from
Nov 25, 2019

Conversation

BrennaEpp
Copy link
Contributor

As of before this commit, no input event was triggered, which meant that the value of an input field would not change until the user made another change in the input field.

It makes sense that pressing enter or clicking to replace some text with Tribute would emit an input event that could be listened for along with other input events.

This fixes a bug when using Tribute on a q-input (from the Quasar framework) - if you click off the input field right after hitting enter or clicking to replace, the replacement text disappears.

@BrennaEpp
Copy link
Contributor Author

@mrsweaters tagging you for visibility as you have most commits/seem to be the owner; not sure how often this repo is updated.

@mrsweaters
Copy link
Collaborator

This looks good. However, this does drop support for IE as new Event is not supported. I'm fine with this as long as you think the market is small enough. If so, let's remove IE9+ from the README.

@BrennaEpp
Copy link
Contributor Author

BrennaEpp commented Nov 25, 2019

This looks good. However, this does drop support for IE as new Event is not supported. I'm fine with this as long as you think the market is small enough. If so, let's remove IE9+ from the README.

Oh, right. I see you're already using the polyfill for CustomEvent. I'll go ahead and update the pull request to use the polyfill from src/utils and change new Event to new CustomEvent, if you're all good with that. That should keep support for IE9+.

@mrsweaters It's updated now!

@mrsweaters
Copy link
Collaborator

Thanks! It looks good!

@mrsweaters mrsweaters merged commit 81536d9 into zurb:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants