Better support for composition on contenteditable (#394) #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get caret position from range instead of marker elem
|
This looks great! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to suggest to change the way it gets caret positions on
contenteditable.the problem is that in some languages like Korean or Japanese,
a character is composed of multiple typings and the current way which is appending marker element & manipulate range breaks composition while typing.
To support composition better, I've changed to get positions from range without any manipulation.
It passes the unit tests of the menu position, but I'd like to get some advice if any case is missing.
Thank you
Related #394