Detach instance #72
Detach instance #72
Conversation
* Allow for manually triggering menu. * More work on trigger-menu. * more work on trigger menu. * Get manual activation working.
|
You are unbinding events from the passed in element, but you're not unbinding the events from the document and window. |
|
Also, when you say the event cleanup isn't working quite right, can you give more details about what is going on? |
|
@omarstreak I pushed an update that removes the global window object bindings. When I said it wasn't working quite right, I meant that there is currently an issue with rebinding to an element after tribute has been detached. I'm currently looking for what might be the cause of that. For the most part, it appears to be working. |
|
Hello, when can this PR be merged? |
|
@biallo I should have some time to merge this in on Monday. Thanks for bringing it to my attention! |
src/Tribute.js
Outdated
| setTimeout(() => { | ||
| el.removeAttribute('data-tribute') | ||
| this.isActive = false | ||
| this.menu.remove() |
There was a problem hiding this comment.
In my usage scenario, after the user opens the input box, it does not necessarily use '@'. At this time, if I use 'detach', an error occurs because the menu is 'undefined' at this time.
if (this.menu) {
this.menu.remove()
}
| } | ||
|
|
||
| } | ||
|
|
||
| unbind(menu) { | ||
| menu.removeEventListener('keydown', |
There was a problem hiding this comment.
In my usage scenario, after the user opens the input box, it does not necessarily use '@'. At this time, if I use 'detach', an error occurs because the menu is 'undefined' at this time.
if (menu) {
menu.removeEventListener('keydown', this.menuKeydownEvent, false);
}
|
any updates? |
| this.menuEvents.unbind(el.tributeMenu); | ||
|
|
||
| setTimeout(function () { | ||
| el.removeAttribute('data-tribute'); |
There was a problem hiding this comment.
Thanks for all the hard work on this feature.
I'm getting a warning from the attach function when I use the detach and attach function back to back:
tribute.detach(element);
tribute = new Tribute({
collection: newValue
});
tribute.attach(element);
Tribute was already bound to DIV
I suspect it's the setTimeout function doing this, but was there a reason for it?
Work in Progress.
This is an attempt at detaching Tribute from a bound instance. However, the event clean up is not working quite right. Some help would be appreciated!
Should address:
#69
#37